remove fresco proguard rules #19040
Closed
remove fresco proguard rules #19040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hramos Do you have time to review this, thanks. |
facebook-github-bot
approved these changes
May 14, 2018
There was a problem hiding this comment.
@hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
macdoum1
pushed a commit
to macdoum1/react-native
that referenced
this pull request
Jun 28, 2018
Summary: Fresco now maintain proguard rules by itself (facebook/fresco#2075), so it won't be necessary for react native copy its rules. Run RNTTester Android app in release mode, app build successful and won't crash in ImageModule. none [ANDROID] [BUGFIX] [PROGUARD] - remove fresco proguard rules Closes facebook#19040 Differential Revision: D7992146 Pulled By: hramos fbshipit-source-id: 9ee3dd4c6756472395ec9e36a967b469f0760999
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fresco now maintain proguard rules by itself (facebook/fresco#2075), so it won't be necessary for react native copy its rules.
Test Plan
Run RNTTester Android app in release mode, app build successful and won't crash in ImageModule.
Related PRs
none
Release Notes
[ANDROID] [BUGFIX] [PROGUARD] - remove fresco proguard rules