Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include Fishhook with check #18811

Closed
wants to merge 1 commit into from
Closed

Include Fishhook with check #18811

wants to merge 1 commit into from

Conversation

LukeDurrant
Copy link
Contributor

@LukeDurrant LukeDurrant commented Apr 11, 2018 •
edited
Loading

Adding to the many fishhook import attempts this is the final final
See discussion on
#18050

Test Plan

#18809

Related PRs

Release Notes

[CATEGORY] [TYPE] [LOCATION] - Message

@react-native-bot react-native-bot added the Missing Changelog This PR appears to be missing a changelog, or they are incorrectly formatted. label Apr 11, 2018
@LukeDurrant LukeDurrant mentioned this pull request Apr 11, 2018
Closed
@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 11, 2018
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@facebook-github-bot
Copy link
Contributor

@LukeDurrant I tried to find reviewers for this pull request and wanted to ping them to take another look. However, based on the blame information for the files in this pull request I couldn't find any reviewers. This sometimes happens when the files in the pull request are new or don't exist on master anymore. Is this pull request still relevant? If yes could you please rebase? In case you know who has context on this code feel free to mention them in a comment (one person is fine). Thanks for reading and hope you will continue contributing to the project.

@LukeDurrant LukeDurrant force-pushed the task/fishhook-import branch from 562a0e4 to a76c390 Compare May 13, 2018 03:15
@facebook-github-bot
Copy link
Contributor

@LukeDurrant I tried to find reviewers for this pull request and wanted to ping them to take another look. However, based on the blame information for the files in this pull request I couldn't find any reviewers. This sometimes happens when the files in the pull request are new or don't exist on master anymore. Is this pull request still relevant? If yes could you please rebase? In case you know who has context on this code feel free to mention them in a comment (one person is fine). Thanks for reading and hope you will continue contributing to the project.

@daneov
Copy link

daneov commented Jun 23, 2018 •
edited
Loading

In the tests something went wrong during the signing step, as far as I can tell, so I'm guessing it's a bit out of your hands right now, but manually applying this does fix the issue, thanks for that 👍 .

@hramos, you mentioned the fishhook issue being resolved in the upcoming release candidate, so does that make this PR redundant? 🤔

Edit: 0.56.0-rc.3 seems to fix the need for orta 's cocoapods plugin, but doesn't fix this error:

/RCTReconnectingWebSocket.m:12:9: 'fishhook/fishhook.h' file not found
#import <fishhook/fishhook.h>
                         ^------------

@brynbodayle brynbodayle mentioned this pull request Jun 27, 2018
Merged
@hramos hramos added Missing Test Plan This PR appears to be missing a test plan. and removed ✅Test Plan labels Jan 15, 2019
@hramos
Copy link
Contributor

hramos commented Jan 15, 2019

Landed in 75a0273#diff-2460e12644d5d61d191bc7c0b674749c

@hramos hramos closed this Jan 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Missing Changelog This PR appears to be missing a changelog, or they are incorrectly formatted. Missing Test Plan This PR appears to be missing a test plan.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@LukeDurrant @facebook-github-bot @daneov @hramos @react-native-bot