Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant config in AndroidManifest.xml #17596

Closed
wants to merge 2 commits into from
Closed

Remove redundant config in AndroidManifest.xml #17596

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
119094a
Remove redundant config in AndroidManifest.xml
gengjiawen Jan 15, 2018
25890c4
avoid lint error
gengjiawen Jan 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions local-cli/templates/HelloWorld/android/app/src/main/AndroidManifest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,14 @@
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
package="com.helloworld"
android:versionCode="1"
android:versionName="1.0">
package="com.helloworld">

<uses-permission android:name="android.permission.INTERNET" />
<uses-permission android:name="android.permission.SYSTEM_ALERT_WINDOW"/>

<uses-sdk
android:minSdkVersion="16"
android:targetSdkVersion="22" />

<application
android:name=".MainApplication"
android:allowBackup="true"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to https://stackoverflow.com/questions/12648373/what-is-androidallowbackup this will cause a lint warning if not set. I think we could just set it to false by default.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@janicduplessis fixed.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it be beneficial to most app users to have automatic backups? Developers who aren't android savvy will not know to change this setting; and malicious user's can root their phone and get the data regardless. At the very least, there should be RN documentation about it.

https://developer.android.com/guide/topics/data/autobackup.html#EnablingAutoBackup

android:label="@string/app_name"
android:icon="@mipmap/ic_launcher"
android:allowBackup="false"
android:theme="@style/AppTheme">
<activity
android:name=".MainActivity"
Expand Down