CI for Android fixed #17551

dryganets · 2018-01-11T21:50:59Z

Fix for android github CI.

Motivation

Github CI doesn't work without this change.

Test Plan

CI passes.

Release Notes

[INTERNAL] Android CI fix.

pull-bot · 2018-01-11T21:53:01Z

	Warnings
⚠️	📋 Release Notes - This PR may have incorrectly formatted Release Notes.

@facebook-github-bot label Needs more information

Generated by 🚫 dangerJS

dryganets · 2018-01-11T22:40:31Z

I rolled back to the commit where iOS tv worked to make all unit tests pass.
tvOS CI is broken in the master.

hramos · 2018-01-11T23:14:45Z

Thanks for fixing this. It was reverted internally due to a misunderstanding because usually Yoga wouldn't need these DEFS. Let's land this for now as it fixes OSS CI until a better long term fix can be implemented.

facebook-github-bot

@hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot

@hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

hramos · 2018-01-11T23:58:09Z

ReactCommon/yoga/BUCK

-fb_xplat_cxx_library(
+include_defs("//ReactCommon/DEFS")
+
+rn_xplat_cxx_library(


Why rn_ and not fb_?

fb is not defined in common. By some reason, all modules in common use this function instead.

hramos · 2018-01-11T23:58:30Z

ReactCommon/DEFS

@@ -2,8 +2,7 @@

 # Building is not supported in OSS right now
 def rn_xplat_cxx_library(name, **kwargs):
-  cxx_library(name = name)
-
+  cxx_library(name, **kwargs)


What is this change for?

**kwargs have a visibility property.
In previous implementation we used to strip it, so modules which are using yoga can't find it as it is private.

dryganets · 2018-01-12T00:18:06Z

There is one more android fail:

File does not exist: buck-out/gen/ReactAndroid/src/main/third-party/java/robolectric3/robolectric/android-all-4.1.2_r1-robolectric-0.jar
java.lang.IllegalArgumentException: File does not exist: buck-out/gen/ReactAndroid/src/main/third-party/java/robolectric3/robolectric/android-all-4.1.2_r1-robolectric-0.jar

dryganets · 2018-01-12T02:43:47Z

All robolectric dependencies by some reason are spread across set of binary-jar directories.
This causes the failure.

I guess it is a result of the BUCK tool update.

dryganets · 2018-01-12T03:15:05Z

@hramos this time it should build for Android.
Somebody needs to fix iosTv linking for x86_64.

dryganets · 2018-01-12T03:34:07Z

yey!
Android passed.
I think it is ready for merge.

dryganets · 2018-01-12T04:20:59Z

This is a commit which broke tvTests:
c491b22

facebook-github-bot · 2018-01-12T12:48:47Z

I tried to merge this pull request into the Facebook internal repo but some checks failed. To unblock yourself please check the following: Does this pull request pass all open source tests on GitHub? If not please fix those. Does the code still apply cleanly on top of GitHub master? If not can please rebase. In all other cases this means some internal test failed, for example a part of a fb app won't work with this pull request. I've added the Import Failed label to this pull request so it is easy for someone at fb to find the pull request and check what failed. If you don't see anyone comment in a few days feel free to comment mentioning one of the core contributors to the project so they get a notification.

facebook-github-bot

@hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

dryganets · 2018-01-13T01:07:50Z

This PR is related and could be closed now:
#17389

Summary: Originally added in #17551 by dryganets but lost when an internal diff consolidated files into ReactNative/DEFS Closes #17710 Differential Revision: D6778242 Pulled By: hramos fbshipit-source-id: 22bd3348feccf1ecb53d897c84e1ca704e51fc33

facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. cla signed labels Jan 11, 2018

ide requested a review from hramos January 11, 2018 21:55

dryganets force-pushed the android-tests-fix branch 2 times, most recently from ee59a51 to 0c10ee5 Compare January 11, 2018 22:39

facebook-github-bot added the Import Started This pull request has been imported. This does not imply the PR has been approved. label Jan 11, 2018

facebook-github-bot approved these changes Jan 11, 2018

View reviewed changes

dryganets force-pushed the android-tests-fix branch from 2487aa7 to 30934d6 Compare January 11, 2018 23:38

hramos reviewed Jan 11, 2018

View reviewed changes

dryganets added 2 commits January 11, 2018 16:00

Travis CI for android fixed

4710661

attempt to fix the build

5b98d9e

dryganets force-pushed the android-tests-fix branch from 30934d6 to 5b98d9e Compare January 12, 2018 00:01

Output paths are changed for robolectric

04fe203

dryganets force-pushed the android-tests-fix branch from f5a8c8d to 04fe203 Compare January 12, 2018 03:12

dryganets changed the title ~~Travis CI fixed~~ Travis CI for Android fixed Jan 12, 2018

dryganets changed the title ~~Travis CI for Android fixed~~ CI for Android fixed Jan 12, 2018

facebook-github-bot added Import Failed and removed Import Started This pull request has been imported. This does not imply the PR has been approved. labels Jan 12, 2018

facebook-github-bot added the Import Started This pull request has been imported. This does not imply the PR has been approved. label Jan 12, 2018

facebook-github-bot approved these changes Jan 12, 2018

View reviewed changes

facebook-github-bot closed this in c8e98bb Jan 12, 2018

hramos mentioned this pull request Jan 22, 2018

[CircleCI] [BUCK] Add back kwargs #17710

Closed

hramos added Merged This PR has been merged. and removed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Mar 8, 2019

react-native-bot removed Import Started This pull request has been imported. This does not imply the PR has been approved. Import Failed labels Mar 8, 2019

elicwhite added p: Microsoft Partner: Microsoft Partner and removed Partner p: Microsoft Partner: Microsoft labels Jul 3, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CI for Android fixed #17551

CI for Android fixed #17551

dryganets commented Jan 11, 2018

pull-bot commented Jan 11, 2018 •

edited

Loading

dryganets commented Jan 11, 2018

hramos commented Jan 11, 2018

facebook-github-bot left a comment

facebook-github-bot left a comment

hramos Jan 11, 2018

dryganets Jan 12, 2018 •

edited

Loading

hramos Jan 11, 2018

dryganets Jan 12, 2018 •

edited

Loading

dryganets commented Jan 12, 2018

dryganets commented Jan 12, 2018

dryganets commented Jan 12, 2018

dryganets commented Jan 12, 2018

dryganets commented Jan 12, 2018

facebook-github-bot commented Jan 12, 2018

facebook-github-bot left a comment

dryganets commented Jan 13, 2018

CI for Android fixed #17551

CI for Android fixed #17551

Conversation

dryganets commented Jan 11, 2018

Motivation

Test Plan

Release Notes

pull-bot commented Jan 11, 2018 • edited Loading

dryganets commented Jan 11, 2018

hramos commented Jan 11, 2018

facebook-github-bot left a comment

Choose a reason for hiding this comment

facebook-github-bot left a comment

Choose a reason for hiding this comment

hramos Jan 11, 2018

Choose a reason for hiding this comment

dryganets Jan 12, 2018 • edited Loading

Choose a reason for hiding this comment

hramos Jan 11, 2018

Choose a reason for hiding this comment

dryganets Jan 12, 2018 • edited Loading

Choose a reason for hiding this comment

dryganets commented Jan 12, 2018

dryganets commented Jan 12, 2018

dryganets commented Jan 12, 2018

dryganets commented Jan 12, 2018

dryganets commented Jan 12, 2018

facebook-github-bot commented Jan 12, 2018

facebook-github-bot left a comment

Choose a reason for hiding this comment

dryganets commented Jan 13, 2018

pull-bot commented Jan 11, 2018 •

edited

Loading

dryganets Jan 12, 2018 •

edited

Loading

dryganets Jan 12, 2018 •

edited

Loading