Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Circle CI] Separate JavaScript lint/flow checks from tests #17293

Closed
wants to merge 2 commits into from
+22 −10
Closed

[Circle CI] Separate JavaScript lint/flow checks from tests #17293

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f1c175f
Separate node tests steps
hramos Dec 20, 2017
947c026
Separate lint/flow checks into a new workflow
hramos Dec 20, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 22 additions & 10 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,9 +96,16 @@ aliases:
- &run-node-tests
|
npm test -- --maxWorkers=2

- &run-lint-checks
|
npm run lint

- &run-flow-checks
|
npm run flow -- check


- &filter-only-master-stable
branches:
only:
Expand Down Expand Up @@ -171,8 +178,8 @@ android_defaults: &android_defaults

version: 2
jobs:
# Runs JavaScript tests on Node 8
test-js-node-8:
# Runs JavaScript lint and flow checks
run-js-checks:
<<: *defaults
docker:
- image: circleci/node:8
Expand All @@ -181,25 +188,26 @@ jobs:
- restore-cache: *restore-node-cache
- run: *install-node-dependencies
- save-cache: *save-node-cache
- run: *run-node-tests
- run: *run-lint-checks
- run: *run-flow-checks

# Runs JavaScript tests on Node 6
test-js-node-6:
# Runs JavaScript tests on Node 8
test-js-node-8:
<<: *defaults
docker:
- image: circleci/node:6.11.0
- image: circleci/node:8
steps:
- checkout
- restore-cache: *restore-node-cache
- run: *install-node-dependencies
- save-cache: *save-node-cache
- run: *run-node-tests

# Runs JavaScript tests on Node 4
test-js-node-4:
# Runs JavaScript tests on Node 6
test-js-node-6:
<<: *defaults
docker:
- image: circleci/node:4.8.4
- image: circleci/node:6
steps:
- checkout
- restore-cache: *restore-node-cache
Expand Down Expand Up @@ -457,7 +465,11 @@ workflows:
build:
jobs:

# Test Javascript on Node 8 and 6
# Run lint and flow checks
- run-js-checks:
filters: *filter-ignore-gh-pages

# Test JavaScript on Node 8 and 6
- test-js-node-8:
filters: *filter-ignore-gh-pages
- test-js-node-6:
Expand Down