Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ImgBot] optimizes images #15897

Closed
wants to merge 1 commit into from
Closed

[ImgBot] optimizes images #15897

wants to merge 1 commit into from

Conversation

ImgBotApp
Copy link

Hey there. I've just optimized all of your images. They are the same dimensions and quality as before, only they take up less space now.

There were a lot of images in there. You can see the details of the space saving in the commit message body.

@ImgBotApp
[ImgBot] optimizes images
a1fb562 
\RNTester\js\Thumbnails\poke.png (0.59%))
\blog\img\button-android-ios.png (17.03%))
\blog\img\animated-diagram.png (6.61%))
\website\src\react-native\img\react-native-android-studio-no-virtual-device-windows.png (38.65%))
\website\src\react-native\img\AndroidDevServerDialog.png (12.25%))
\website\src\react-native\img\react-native-android-studio-verify-installs-windows.png (44.53%))
\blog\img\dark-hero.png (49.96%))
\blog\img\rtl-ama-android-hebrew.png (11.6%))
\website\src\react-native\img\AndroidDevSettings.png (12.39%))
\IntegrationTests\blue_square.png (34.38%))
\Libraries\Image\__tests__\img\img1.png (14.74%))
\RNTester\RNTester\Images.xcassets\NavBarButtonPlus.imageset\NavBarButtonPlus@3x.png (26.51%))
\RNTester\RNTester\Images.xcassets\tabnav_list.imageset\tabnav_list@3x.png (17.5%))
\Libraries\Image\__tests__\img\img2.png (14.74%))
\IntegrationTests\red_square.png (34.88%))
\RNTester\RNTester\Images.xcassets\story-background.imageset\story-background@2x.png (19.94%))
\local-cli\templates\HelloWorld\android\app\src\main\res\mipmap-hdpi\ic_launcher.png (8.66%))
\blog\img\yarn-rncli.png (35.69%))
\blog\img\git-upgrade-output.png (13.29%))
\website\src\react-native\img\react-native-android-tools-environment-variable-windows.png (75.71%))
\RNTester\android\app\src\main\res\drawable\ic_create_black_48dp.png (14.53%))
\website\src\react-native\img\AndroidEnvironmentVariableANDROID_HOME.png (40.62%))
\local-cli\templates\HelloNavigation\views\chat\chat-icon.png (19.12%))
\RNTester\RNTester\RNTesterBundle\ImageInBundle.png (3.78%))
\website\src\react-native\img\react-native-existing-app-integration-ios-before.png (40.75%))
\website\src\react-native\img\react-native-sorry-not-supported.png (3.08%))
\local-cli\templates\HelloNavigation\views\welcome\welcome-icon.png (32.25%))
\RNTester\android\app\src\main\res\drawable\ic_menu_black_24dp.png (39.66%))
\website\src\react-native\img\AndroidSDKManagerInstallsMacOS.png (20.42%))
\RNTester\RNTester\RNTesterBundle\OtherImages.xcassets\ImageInAssetCatalog.imageset\react-logo.png (3.78%))
\RNTester\js\relay@3x.png (28.03%))
\local-cli\templates\HelloWorld\android\app\src\main\res\mipmap-mdpi\ic_launcher.png (11.33%))
\website\src\react-native\img\AndroidSDK2.png (2.31%))
\blog\img\hmr-architecture.png (11.77%))
\RNTester\RNTesterIntegrationTests\blue_square.png (34.38%))
\RNTester\RNTesterIntegrationTests\ReferenceImages\IntegrationTests-IntegrationTestsApp\testImageSnapshotTest_1@2x.png (92.26%))
\RNTester\js\slider-left.png (81.15%))
\website\src\react-native\img\react-native-congratulations.png (1.74%))
\RNTester\js\uie_thumb_normal@2x.png (2.59%))
\RNTester\js\Thumbnails\dislike.png (0.22%))
\website\src\react-native\img\react-native-tools-avd.png (82.72%))
\website\src\react-native\img\AndroidSDK1.png (1.54%))
\RNTester\android\app\src\main\res\drawable\ic_settings_black_48dp.png (3.18%))
\RNTester\js\Thumbnails\flowers.png (0.05%))
\RNTester\js\slider-left@2x.png (78.86%))
\local-cli\templates\HelloWorld\android\app\src\main\res\mipmap-xhdpi\ic_launcher.png (9.83%))
\website\src\react-native\img\react-native-sdk-platforms.png (25.94%))
\website\src\react-native\img\AndroidSDKManagerInstallsWindows.png (2.94%))
\RNTester\RNTesterIntegrationTests\ReferenceImages\RNTester-js-RNTesterApp.ios\testLayoutExample_1-iOS10@2x.png (24.88%))
\RNTester\js\slider-right.png (80.83%))
\website\src\react-native\img\AndroidSDKManagerMacOS.png (23.34%))
\RNTester\js\Thumbnails\like.png (0.44%))
\local-cli\templates\HelloWorld\android\app\src\main\res\mipmap-xxhdpi\ic_launcher.png (9.21%))
\RNTester\js\Thumbnails\bandaged.png (0.36%))
\website\src\react-native\img\ReboundExample.png (21.29%))
\RNTester\RNTesterIntegrationTests\red_square.png (34.88%))
\website\src\react-native\img\StaticImageAssets.png (20.57%))
\RNTester\RNTesterIntegrationTests\ReferenceImages\RNTester-js-RNTesterApp.ios\testSliderExample_1-iOS10@2x.png (31.09%))
\website\src\react-native\img\AndroidSDKManagerSDKToolsWindows.png (62.94%))
\website\src\react-native\img\survey.png (2.26%))
\RNTester\js\flux@3x.png (19.54%))
\RNTester\RNTesterIntegrationTests\ReferenceImages\RNTester-js-RNTesterApp.ios\testLayoutExample_1-iOS10_tvOS.png (33.03%))
\RNTester\js\slider-right@2x.png (79.05%))
\website\src\react-native\img\AVDManagerMacOS.png (34.91%))
\RNTester\RNTesterIntegrationTests\ReferenceImages\RNTester-js-RNTesterApp.ios\testTextExample_1-iOS10@2x.png (6.38%))
\RNTester\js\slider.png (78.04%))
\website\src\react-native\img\ReactDevTools.png (7.68%))
\RNTester\RNTesterIntegrationTests\ReferenceImages\IntegrationTests-IntegrationTestsApp\testImageSnapshotTest_1_tvOS.png (97.19%))
\RNTester\RNTesterIntegrationTests\ReferenceImages\RNTester-js-RNTesterApp.ios\testLayoutExample_1@2x.png (25.04%))
\website\src\react-native\img\AndroidStudioWelcomeWindows.png (22.83%))
\website\src\react-native\img\iOSSuccess.png (41.25%))
\website\src\react-native\img\RunningOnDeviceCodeSigning.png (22.94%))
\website\src\react-native\img\CreateAVDx86MacOS.png (36.45%))
\website\src\react-native\img\SystraceBadJS2.png (25.75%))
\website\src\react-native\img\AndroidSDKManagerWindows.png (32.84%))
\website\src\react-native\img\react-native-add-react-native-integration-wire-up.png (35.64%))
\RNTester\RNTesterIntegrationTests\ReferenceImages\RNTester-js-RNTesterApp.ios\testSliderExample_1@2x.png (31.23%))
\RNTester\js\slider@2x.png (71.43%))
\website\src\react-native\img\AndroidSDKManagerSDKToolsMacOS.png (23.65%))
\website\src\react-native\img\SystraceBadCreateUI.png (25.85%))
\website\src\react-native\img\ObjectObserveError.png (67.3%))
\website\src\react-native\img\RunningOnDeviceReady.png (37.62%))
\website\src\react-native\img\DeveloperMenu.png (25.08%))
\website\src\react-native\img\AVDManagerWindows.png (24.87%))
\website\src\react-native\img\SystraceBadUI.png (29.16%))
\RNTester\RNTesterIntegrationTests\ReferenceImages\RNTester-js-RNTesterApp.ios\testTextExample_1-iOS10_tvOS.png (20.17%))
\RNTester\RNTesterIntegrationTests\ReferenceImages\RNTester-js-RNTesterApp.ios\testLayoutExample_1_tvOS.png (34.3%))
\website\src\react-native\img\SystraceBadJS.png (34.08%))
\website\src\react-native\img\react-native-android-studio-additional-installs-linux.png (56.38%))
\website\src\react-native\img\PerfUtil.png (17.85%))
\website\src\react-native\img\Button.png (19.73%))
\website\src\react-native\img\SystraceExample.png (25.65%))
\website\src\react-native\img\AndroidStudioCustomSetup.png (6.52%))
\RNTester\js\uie_comment_highlighted@2x.png (1.49%))
\website\src\react-native\img\SystraceHighlightVSync.png (50.04%))
\RNTester\RNTesterIntegrationTests\ReferenceImages\RNTester-js-RNTesterApp.ios\testScrollViewExample_1-iOS10@2x.png (36.91%))
\website\src\react-native\img\SystraceJSThreadExample.png (39.28%))
\website\src\react-native\img\buttonExample.png (12.8%))
\website\src\react-native\img\search.png (79.75%))
\website\src\react-native\img\react-native-add-react-native-integration-example-high-scores.png (65.36%))
\RNTester\RNTesterIntegrationTests\ReferenceImages\RNTester-js-RNTesterApp.ios\testSwitchExample_1-iOS10@2x.png (37.73%))
\RNTester\RNTesterIntegrationTests\ReferenceImages\RNTester-js-RNTesterApp.ios\testTextExample_1@2x.png (6.49%))
\website\src\react-native\img\EmbeddedAppAndroid.png (58.24%))
\website\src\react-native\img\react-native-android-studio-custom-install-windows.png (51.02%))
\website\src\react-native\img\SystraceNativeModulesThreadExample.png (48.27%))
\website\src\react-native\img\react-native-add-react-native-integration-example-home-screen.png (35.08%))
\website\src\react-native\img\SystraceRenderThreadExample.png (36.86%))
\website\src\react-native\img\react-native-android-studio-additional-installs.png (32.54%))
\website\src\react-native\img\TutorialMock2.png (31.11%))
\website\src\react-native\img\AndroidSuccessMacOS.png (24.75%))
\website\src\react-native\img\react-native-add-react-native-integration-link.png (65.08%))
\website\src\react-native\img\AndroidStudioWelcomeMacOS.png (19.85%))
\RNTester\RNTesterIntegrationTests\ReferenceImages\RNTester-js-RNTesterApp.ios\testScrollViewExample_1-iOS10_tvOS.png (47.03%))
\website\src\react-native\img\XcodeBuildIP.png (7.92%))
\website\src\react-native\img\react-native-android-studio-custom-install.png (40.3%))
\blog\img\rnmsf-august-2016-netflix.jpg (35.7%))
\RNTester\RNTesterIntegrationTests\ReferenceImages\RNTester-js-RNTesterApp.ios\testTextExample_1_tvOS.png (21.54%))
\website\src\react-native\img\SystraceUIThreadExample.png (45.14%))
\website\src\react-native\img\EmbeddedAppContainerViewExample.png (30.78%))
\website\src\react-native\img\ConfigureReleaseScheme.png (28.36%))
\website\src\react-native\img\TutorialSingleFetched2.png (28.48%))
\RNTester\RNTesterIntegrationTests\ReferenceImages\RNTester-js-RNTesterApp.ios\testSwitchExample_1@2x.png (37.98%))
\website\src\react-native\img\EmbeddedAppExample.png (27.11%))
\website\src\react-native\img\react-native-android-studio-android-sdk-build-tools-linux.png (56.31%))
\website\src\react-native\img\XcodeCommandLineTools.png (39.36%))
\website\src\react-native\img\SystraceWellBehaved.png (37.82%))
\website\src\react-native\img\TutorialFinal2.png (6.61%))
\website\src\react-native\img\showcase\wmt_spark.png (57.58%))
\Libraries\Animated\examples\pic1.jpg (3.94%))
\RNTester\RNTesterIntegrationTests\ReferenceImages\RNTester-js-RNTesterApp.ios\testScrollViewExample_1@2x.png (36.66%))
\RNTester\RNTesterIntegrationTests\ReferenceImages\RNTester-js-RNTesterApp.ios\testTabBarExample_1-iOS10@2x.png (62.66%))
\blog\img\big-hero.jpg (2.3%))
\RNTester\RNTesterIntegrationTests\ReferenceImages\RNTester-js-RNTesterApp.ios\testViewExample_1-iOS10@2x.png (23.59%))
\website\src\react-native\img\react-native-android-studio-kvm-linux.png (59.16%))
\website\src\react-native\img\CreateAVDMacOS.png (17.32%))
\website\src\react-native\img\TutorialStyledMock2.png (30.43%))
\website\src\react-native\img\AndroidSuccessWindows.png (25.58%))
\RNTester\RNTesterIntegrationTests\ReferenceImages\IntegrationTests-IntegrationTestsApp\testSimpleSnapshotTest_1@2x.png (98.51%))
\website\src\react-native\img\react-native-android-studio-android-sdk-build-tools-windows.png (40.65%))
\website\src\react-native\img\CreateAVDWindows.png (4.1%))
\blog\img\blue-hero.jpg (0.73%))
\Libraries\Animated\examples\pic2.jpg (1.11%))
\website\src\react-native\img\uiexplorer_main_android.png (21.4%))
\RNTester\RNTesterIntegrationTests\ReferenceImages\RNTester-js-RNTesterApp.ios\testViewExample_1-iOS10_tvOS.png (30.7%))
\RNTester\RNTesterIntegrationTests\ReferenceImages\RNTester-js-RNTesterApp.ios\testTabBarExample_1-iOS10_tvOS.png (53.81%))
\RNTester\RNTesterIntegrationTests\ReferenceImages\RNTester-js-RNTesterApp.ios\testScrollViewExample_1_tvOS.png (48.83%))
\blog\img\rnmsf-august-2016-airbnb.jpg (38.76%))
\RNTester\RNTesterIntegrationTests\ReferenceImages\RNTester-js-RNTesterApp.ios\testViewExample_1@2x.png (23.37%))
\website\src\react-native\img\react-native-android-studio-android-sdk-build-tools.png (26.06%))
\blog\img\rnmsf-august-2016-docs.jpg (33.99%))
\Libraries\Animated\examples\pic3.jpg (2.83%))
\website\src\react-native\img\uiexplorer_main_ios.png (20.84%))
\RNTester\RNTesterIntegrationTests\ReferenceImages\RNTester-js-RNTesterApp.ios\testTabBarExample_1@2x.png (62.73%))
\blog\img\rnmsf-august-2016-hero.jpg (2.87%))
\RNTester\js\AnimatedGratuitousApp\trees.jpg (16.6%))
\website\src\react-native\img\react-native-android-studio-android-sdk-platforms-linux.png (54.2%))
\RNTester\RNTesterIntegrationTests\ReferenceImages\IntegrationTests-IntegrationTestsApp\testSimpleSnapshotTest_1_tvOS.png (98.11%))
\website\src\react-native\img\Warning.png (14.38%))
\website\src\react-native\img\author.png (68.12%))
\RNTester\RNTesterIntegrationTests\ReferenceImages\RNTester-js-RNTesterApp.ios\testTabBarExample_1_tvOS.png (56.96%))
\RNTester\RNTesterIntegrationTests\ReferenceImages\RNTester-js-RNTesterApp.ios\testViewExample_1_tvOS.png (31.75%))
\website\src\react-native\img\TodayWidgetUnableToLoad.jpg (17.79%))
\website\src\react-native\img\react-native-android-studio-android-sdk-platforms-windows.png (42.08%))
\website\src\react-native\img\react-native-android-studio-android-sdk-platforms.png (24.6%))
\website\src\react-native\img\AddToBuildPhases.png (14.8%))
\website\src\react-native\img\react-native-android-studio-avd-linux.png (41.05%))
\RNTester\RNTesterIntegrationTests\ReferenceImages\RNTester-js-RNTesterApp.ios\testARTExample_1-iOS10@2x.png (67.63%))
\website\src\react-native\img\react-native-android-studio-avd-windows.png (46.9%))
\website\src\react-native\img\AddToLibraries.png (12.53%))
\website\src\react-native\img\react-native-android-studio-avd.png (28.42%))
\website\src\react-native\img\react-native-android-studio-configure-sdk-linux.png (51.32%))
\RNTester\RNTesterIntegrationTests\ReferenceImages\RNTester-js-RNTesterApp.ios\testARTExample_1-iOS10_tvOS.png (57.28%))
\website\src\react-native\img\react-native-android-studio-configure-sdk-windows.png (45.54%))
\website\src\react-native\img\AddToSearchPaths.png (15.68%))
\website\src\react-native\img\AdministratorCommandPrompt.png (20.45%))
\website\src\react-native\img\react-native-android-studio-configure-sdk.png (36.78%))
\website\src\react-native\img\alertIOS.png (27.87%))
\website\src\react-native\img\react-native-android-studio-custom-install-linux.png (58.14%))
\RNTester\RNTesterIntegrationTests\ReferenceImages\RNTester-js-RNTesterApp.ios\testARTExample_1@2x.png (67.62%))
\website\src\react-native\img\AndroidAVDConfiguration.png (46.9%))
\RNTester\RNTesterIntegrationTests\ReferenceImages\RNTester-js-RNTesterApp.ios\testARTExample_1_tvOS.png (57.29%))
\website\src\react-native\img\AndroidDeveloperMenu.png (53.94%))
@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@pull-bot
Copy link

Warnings
⚠️

📝 Blog post - This PR appears to edit an existing blog post, and may require further review from the React Native team.
⚠️

📋 Test Plan - This PR appears to be missing a Test Plan.

@facebook-github-bot label Needs more information

Generated by 🚫 dangerJS

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 12, 2017
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@elicwhite
Copy link
Member

This is pretty neat.

We probably don't want to compress any of the ReferenceImages since I believe those came from screenshot tests.

@dabutvin
Copy link

thanks @TheSavior

We are planning to add a .imgbotconfig to enable these kind of whitelist/blacklist of images directories
https://github.com/dabutvin/ImgBot/issues/2

for now, the service will try to optimize all of your images it can find in the repo.

@elicwhite
Copy link
Member

Got it. This seems like it will be a neat bot for the open source community.

Unfortunately, we won't be able to merge this as is because of the screenshot test images. I think the directories that need to be not compressed are more than just the one I mentioned before. @sahrens would have a better idea on the folders.

I'm going to close this PR since it seems unlikely that someone will go through the images in the commit and revert some of them manually. Maybe we can revisit this once the config is supported.

@elicwhite elicwhite closed this Sep 13, 2017
@ImgBotApp ImgBotApp mentioned this pull request Oct 29, 2017
Closed
@dabutvin
Copy link

@TheSavior I released an update for ImgBot and opened a new PR with the configuration #16591

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ImgBotApp @facebook-github-bot @pull-bot @elicwhite @dabutvin