default value for javaScriptEnabled is false

[koenpunt]

This did cost me quite some time, but it turns out the default value for javaScriptEnabled isn't true, but false. So without it, any JavaScript injected through injectJavaScript/injectedJavaScript won't ever make it to the webview.

Ref: https://developer.android.com/reference/android/webkit/WebSettings.html#setJavaScriptEnabled(boolean)

[charpeni]

I guess that the default value was referring to defaultProps, not Android one.

static defaultProps = {
  javaScriptEnabled : true,
  scalesPageToFit: true,
};

https://github.com/koenpunt/react-native/blob/master/Libraries/Components/WebView/WebView.android.js#L188

[koenpunt]

@charpeni probably, but the default prop apparently isn't passed to the native view?

[koenpunt]

So my change might not be applicable, but there's an issue with it nonetheless.

[facebook-github-bot]

@koenpunt I tried to find reviewers for this pull request and wanted to ping them to take another look. However, based on the blame information for the files in this pull request I couldn't find any reviewers. This sometimes happens when the files in the pull request are new or don't exist on master anymore. Is this pull request still relevant? If yes could you please rebase? In case you know who has context on this code feel free to mention them in a comment (one person is fine). Thanks for reading and hope you will continue contributing to the project.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Maybe the issue has been fixed in a recent release, or perhaps it is not affecting a lot of people. If you think this issue should definitely remain open, please let us know why. Thank you for your contributions.