[Android] Support additional dependency declaration format

[gilesvangruisen]

Thanks for submitting a PR! Please read these instructions carefully:

• Explain the motivation for making this change.
• Provide a test plan demonstrating that the code is solid.
• Match the code formatting of the rest of the codebase.
• Target the master branch, NOT a "stable" branch.

Motivation (required)

Previously, isInstalled was somewhat naively checking for the presence
of a string in the build.gradle file to determine whether or not that
dependency was already linked. I.e.:

    compile project(':${name}')\n

…where name is replaced with the name of the dependency being checked.

This was inflexible as it only supported that particular format of
compile definition. Another, valid compile definition follows:

    compile(project(':example') { … }

However, this failed the check because it didn't exactly match the
format for which the check was searching the build.gradle contents. As
a result, running react-native link would incorrectly duplicate the
dependency definition and thus cause a crash upon launching the app.

This change adds an installPattern to the object returned from
makeBuildPatch, which includes the particular dependency name and is
valid for both compile definition formats.

Test Plan (required)

This commit adds an additional compile definition in the associated fixture,
an additional test case in isInstalled.spec.js to check for this additional
format, and an additional test in makeBuildPatch.spec.js to ensure the
object returned includes the aforementioned installPattern Regex pattern.

Next Steps

Sign the CLA, if you haven't already. ✅

Small pull requests are much easier to review and more likely to get merged. Make sure the PR does only one thing, otherwise please split it. ✅

Make sure all tests pass on both Travis and Circle CI. PRs that break tests are unlikely to be merged.

For more info, see the "Pull Requests" section of our "Contributing" guidelines.

[gilesvangruisen]

I can't seem to figure out why these Travis CI builds are failing. Any insight?

[gilesvangruisen]

bump

Anyone available to take a look and (hopefully) help me get this merged? Thanks!

[facebook-github-bot]

@hramos has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.