Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard will show documentation #14350

Closed
wants to merge 6 commits into from
Closed

Keyboard will show documentation #14350

Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
063b3ae
Added documentation for keyboardWillShow
TinoADev Jun 6, 2017
a6c631e
Changed Formatting
TinoADev Jun 6, 2017
4d851a6
Changed wording
TinoADev Jun 7, 2017
365ee26
Merge branch 'master' into keyboardWillShow-documentation
TinoADev Jun 7, 2017
2199e8a
Update Keyboard.js
shergin Jun 19, 2017
5adc3c5
Merge branch 'master' into keyboardWillShow-documentation
shergin Jun 19, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Libraries/Components/Keyboard/Keyboard.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,9 @@ let Keyboard = {
* - `keyboardDidChangeFrame`
*
* Note that if you set `android:windowSoftInputMode` to `adjustResize` or `adjustNothing`,
* only `keyboardDidShow` and `keyboardDidHide` events will available on Android.
* only `keyboardDidShow` and `keyboardDidHide` events will be available on Android and
* `keyboardWillShow` as well as `keyboardWillHide` are generally not available on Android
* since there is no corresponding event.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The relationship between android:windowSoftInputMode, [keyboardDidShow + keyboardDidHide], and [keyboardWillShow + keyboardWillHide] is still unclear to me. Does android:windowSoftInputMode affect [keyboardWillShow + keyboardWillHide], or this pair of events generally unavailable on Android?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keyboardWillShow and keyboardWillHide are not available on Android. There is just no event for that. (As of now, might of course change in the future (hopefully)).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there anything more you like to know?

*
* @param {function} callback function to be called when the event fires.
*/
Expand Down