Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Summary: YellowBox currently assumes the first arg is a printf like format string, this adds support for any arguments so it works more like console in the browser. This also adds `stringifySafe` to format arguments when using printf style. The main annoyance that this fixes is when trying to log a single object it will currently print [object Object] instead of the fully stringified version. **Test plan** Tested a bunch of different log combinations. ```js console.warn({test: 'a'}); // {"test":"a"} (was [object Object] before this patch) console.warn('test %s %s', 1, {}); // test 1 {} console.warn('test %s', 1, {}); // test 1 {} console.warn({}, {}, {}, {}); // {} {} {} {} ``` Closes #16132 Differential Revision: D5973125 Pulled By: yungsters fbshipit-source-id: fc17105a79473a11c9b1c4728d435fc54fb094bb
- Loading branch information
eae4fe8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice one 😎