Skip to content

Commit

Permalink
Include cxx modules in codegen schema (#48581)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: #48581

Previously the CXX only modules were not being inclued in the schema for these apps, and therefore weren't being caught by the compat check.

Reviewed By: cipolleschi

Differential Revision: D68000360

fbshipit-source-id: 5d56bc840bd220f3b8b814e5d90eb49d9a2beb0b
  • Loading branch information
elicwhite authored and facebook-github-bot committed Jan 10, 2025
1 parent db57080 commit cf5ab03
Showing 1 changed file with 12 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -71,11 +71,18 @@ for (const file of schemaFiles) {
);
}

if (
module.excludedPlatforms &&
module.excludedPlatforms.indexOf(platform) >= 0
) {
continue;
const excludedPlatforms = module.excludedPlatforms?.map(
excludedPlatform => excludedPlatform.toLowerCase(),
);

if (excludedPlatforms != null) {
const cxxOnlyModule =
excludedPlatforms.includes('ios') &&
excludedPlatforms.includes('android');

if (!cxxOnlyModule && excludedPlatforms.includes(platform)) {
continue;
}
}

modules[specName] = module;
Expand Down

0 comments on commit cf5ab03

Please sign in to comment.