Skip to content

Commit

Permalink
Fabric: Removing yogaStyleFromLayoutConstraints from RootShadowNode
Browse files Browse the repository at this point in the history
Summary:
We don't need it anymore because the same logic is already implemented in `YogaLayoutableShadowNode::layoutTree()`.

Changelog: [Internal] Fabric-specific internal change.

Reviewed By: sammy-SC

Differential Revision: D20464175

fbshipit-source-id: 3dd2293ee102a9b67a856104720d3a7dc4103d7f
  • Loading branch information
shergin authored and facebook-github-bot committed Mar 16, 2020
1 parent 1f4535c commit c6e224e
Showing 1 changed file with 1 addition and 22 deletions.
23 changes: 1 addition & 22 deletions ReactCommon/fabric/components/root/RootProps.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -13,25 +13,6 @@
namespace facebook {
namespace react {

static YGStyle yogaStyleFromLayoutConstraints(
LayoutConstraints const &layoutConstraints) {
auto yogaStyle = YGStyle{};
yogaStyle.minDimensions()[YGDimensionWidth] =
yogaStyleValueFromFloat(layoutConstraints.minimumSize.width);
yogaStyle.minDimensions()[YGDimensionHeight] =
yogaStyleValueFromFloat(layoutConstraints.minimumSize.height);

yogaStyle.maxDimensions()[YGDimensionWidth] =
yogaStyleValueFromFloat(layoutConstraints.maximumSize.width);
yogaStyle.maxDimensions()[YGDimensionHeight] =
yogaStyleValueFromFloat(layoutConstraints.maximumSize.height);

yogaStyle.direction() =
yogaDirectionFromLayoutDirection(layoutConstraints.layoutDirection);

return yogaStyle;
}

RootProps::RootProps(RootProps const &sourceProps, RawProps const &rawProps)
: ViewProps(sourceProps, rawProps) {}

Expand All @@ -41,9 +22,7 @@ RootProps::RootProps(
LayoutContext const &layoutContext)
: ViewProps(),
layoutConstraints(layoutConstraints),
layoutContext(layoutContext) {
yogaStyle = yogaStyleFromLayoutConstraints(layoutConstraints);
};
layoutContext(layoutContext){};

} // namespace react
} // namespace facebook

0 comments on commit c6e224e

Please sign in to comment.