Skip to content

Commit

Permalink
Fix Dependencies of RCTFabric for RCTInterpolateColorInRange (#48753)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: #48753

[This commit](cc89ddd) introduced a dependency between RCTFabric and RCTAnimation because RCTFabric is now using `RCTInterpolateColorInRange` which is defined in `RCTAnimation`.

To unblock the CI, I'm adding the dependency to the RCTFabric.podspec

However, I'm not convinced that this is the proper fix. We should move the function to a common dependency between RCTFabric and RCTAnimation. Probably in `RCTUtils`.

## Changelog:
[Internal] - Fix CI by making RCTFabric depend on RCTAnimation

Reviewed By: GijsWeterings

Differential Revision: D68322935

fbshipit-source-id: 57c8833e348fb69dc1b1703ffeedd3383405b4f8
  • Loading branch information
cipolleschi authored and facebook-github-bot committed Jan 17, 2025
1 parent a0ddcd2 commit a7aed70
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions packages/react-native/React/React-RCTFabric.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@ Pod::Spec.new do |s|
add_dependency(s, "React-rendererdebug")
add_dependency(s, "React-rendererconsistency")
add_dependency(s, "React-runtimescheduler")
add_dependency(s, "React-RCTAnimation", :framework_name => 'RCTAnimation')
add_dependency(s, "React-jsinspector", :framework_name => 'jsinspector_modern')
add_dependency(s, "React-jsinspectortracing", :framework_name => 'jsinspector_moderntracing')

Expand Down

0 comments on commit a7aed70

Please sign in to comment.