Skip to content

Commit

Permalink
circleci eslint warnings
Browse files Browse the repository at this point in the history
  • Loading branch information
fabOnReact committed Dec 13, 2022
1 parent 88cbc2c commit 868f598
Show file tree
Hide file tree
Showing 8 changed files with 11 additions and 14 deletions.
2 changes: 1 addition & 1 deletion Libraries/Animated/nodes/AnimatedValue.js
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ const NativeAnimatedAPI = NativeAnimatedHelper.API;
* transform which can receive values from multiple parents.
*/
export function flushValue(rootNode: AnimatedNode): void {
const leaves = new Set<{update: () => void, ...}>();
const leaves = new Set<{update:() => void, ...}>();
function findAnimatedStyles(node: AnimatedNode) {
// $FlowFixMe[prop-missing]
if (typeof node.update === 'function') {
Expand Down
2 changes: 1 addition & 1 deletion Libraries/Components/Switch/Switch.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,10 @@ import type {ColorValue} from '../../StyleSheet/StyleSheet';
import type {SyntheticEvent} from '../../Types/CoreEventTypes';
import type {ViewProps} from '../View/ViewPropTypes';

import ViewAncestor from '../View/ViewAncestor';
import StyleSheet from '../../StyleSheet/StyleSheet';
import Platform from '../../Utilities/Platform';
import useMergeRefs from '../../Utilities/useMergeRefs';
import ViewAncestor from '../View/ViewAncestor';
import AndroidSwitchNativeComponent, {
Commands as AndroidSwitchCommands,
} from './AndroidSwitchNativeComponent';
Expand Down
4 changes: 2 additions & 2 deletions Libraries/Components/TextInput/TextInput.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ import type {
} from '../../Types/CoreEventTypes';
import type {ViewProps} from '../View/ViewPropTypes';
import type {TextInputType} from './TextInput.flow';
import ViewAncestor from '../View/ViewAncestor';

import usePressability from '../../Pressability/usePressability';
import flattenStyle from '../../StyleSheet/flattenStyle';
Expand All @@ -29,13 +28,14 @@ import Text from '../../Text/Text';
import TextAncestor from '../../Text/TextAncestor';
import Platform from '../../Utilities/Platform';
import useMergeRefs from '../../Utilities/useMergeRefs';
import ViewAncestor from '../View/ViewAncestor';
import TextInputState from './TextInputState';
import invariant from 'invariant';
import nullthrows from 'nullthrows';
import * as React from 'react';
import {
useContext,
useCallback,
useContext,
useLayoutEffect,
useRef,
useState,
Expand Down
2 changes: 1 addition & 1 deletion Libraries/Components/View/View.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ import type {ViewProps} from './ViewPropTypes';

import flattenStyle from '../../StyleSheet/flattenStyle';
import TextAncestor from '../../Text/TextAncestor';
import ViewAncestor from './ViewAncestor';
import {getAccessibilityRoleFromRole} from '../../Utilities/AcessibilityMapping';
import ViewAncestor from './ViewAncestor';
import ViewNativeComponent from './ViewNativeComponent';
import * as React from 'react';
import {useContext} from 'react';
Expand Down
2 changes: 1 addition & 1 deletion Libraries/Text/Text.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,14 @@
import type {PressEvent} from '../Types/CoreEventTypes';
import type {TextProps} from './TextProps';

import ViewAncestor from '../Components/View/ViewAncestor';
import * as PressabilityDebug from '../Pressability/PressabilityDebug';
import usePressability from '../Pressability/usePressability';
import flattenStyle from '../StyleSheet/flattenStyle';
import processColor from '../StyleSheet/processColor';
import {getAccessibilityRoleFromRole} from '../Utilities/AcessibilityMapping';
import Platform from '../Utilities/Platform';
import TextAncestor from './TextAncestor';
import ViewAncestor from '../Components/View/ViewAncestor';
import {NativeText, NativeVirtualText} from './TextNativeComponent';
import * as React from 'react';
import {useContext, useMemo, useState} from 'react';
Expand Down
2 changes: 1 addition & 1 deletion Libraries/Text/TextProps.js
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ export type TextProps = $ReadOnly<{|
* For iOS see https://bit.ly/3P2jItf
*/
accessibilityLiveRegion?: ?('none' | 'polite' | 'assertive'),
'aria-live'?: ?('polite' | 'assertive' | 'off'),

onAccessibilityAction?: ?(event: AccessibilityActionEvent) => mixed,
accessibilityHint?: ?Stringish,
Expand Down Expand Up @@ -100,6 +99,7 @@ export type TextProps = $ReadOnly<{|
'aria-checked'?: ?boolean | 'mixed',
'aria-disabled'?: ?boolean,
'aria-expanded'?: ?boolean,
'aria-live'?: ?('polite' | 'assertive' | 'off'),
'aria-selected'?: ?boolean,

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,7 @@ - (void)mountChildComponentView:(UIView<RCTComponentViewProtocol> *)childCompone
childComponentView,
@(index),
@([childComponentView.superview tag]));

if (_removeClippedSubviews) {
[_reactSubviews insertObject:childComponentView atIndex:index];
} else {
Expand Down Expand Up @@ -295,9 +296,8 @@ - (void)updateProps:(Props::Shared const &)props oldProps:(Props::Shared const &
self.accessibilityLiveRegion = newViewProps.accessibilityLiveRegion;
}

BOOL isReactRootView = RCTIsReactRootView(self.reactTag);
BOOL accessibilityLiveRegionEnabled = newViewProps.accessible && newViewProps.accessibilityLiveRegion != AccessibilityLiveRegion::None;
BOOL shouldAnnounceLiveRegionChanges = accessibilityLiveRegionEnabled && !isReactRootView;
BOOL shouldAnnounceLiveRegionChanges = accessibilityLiveRegionEnabled && ![self isReactRootView];

// `accessibilityLabel`
if (oldViewProps.accessibilityLabel != newViewProps.accessibilityLabel) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ const {
Platform,
Switch,
ScrollView,
Pressable,
} = require('react-native');
import type {EventSubscription} from 'react-native/Libraries/vendor/emitter/EventEmitter';

Expand Down Expand Up @@ -1585,7 +1584,6 @@ function DisplayOptionStatusExample({

function AccessibilityLiveRegion(): React.Node {
const [count, setCount] = React.useState(0);
const [messageCount, setMessageCount] = React.useState(0);
const [enabled, setEnabled] = React.useState(false);
const [disabled, setDisabled] = React.useState(false);
const [liveRegion, setLiveRegion] = React.useState(true);
Expand All @@ -1594,14 +1592,13 @@ function AccessibilityLiveRegion(): React.Node {
<>
<RNTesterBlock title="LiveRegion with Text Component">
<TouchableWithoutFeedback
onPress={() => setDisabled(disabled => !disabled)}>
onPress={() => setDisabled(previousState => !previousState)}>
<View style={styles.embedded}>
<Text>Click me to set Text state disabled</Text>
</View>
</TouchableWithoutFeedback>
<View>
<View aria-live="polite">
<Text
aria-live="polite"
accessible
accessibilityLabel={disabled ? 'label1' : 'label2'}
accessibilityState={{disabled: disabled}}>
Expand Down

0 comments on commit 868f598

Please sign in to comment.