Merge branch 'iOS_packager_port' of https://github.com/DaKaZ/react-na…

…tive into iOS_packager_port

.flowconfig

@@ -46,12 +46,12 @@ suppress_type=$FlowFixMeProps
 suppress_type=$FlowFixMeState
 suppress_type=$FixMe
 
-suppress_comment=\\(.\\|\n\\)*\\$FlowFixMe\\($\\|[^(]\\|(\\(>=0\\.\\(5[0-4]\\|[1-4][0-9]\\|[0-9]\\).[0-9]\\)? *\\(site=[a-z,_]*react_native_oss[a-z,_]*\\)?)\\)
-suppress_comment=\\(.\\|\n\\)*\\$FlowIssue\\((\\(>=0\\.\\(5[0-4]\\|[1-4][0-9]\\|[0-9]\\).[0-9]\\)? *\\(site=[a-z,_]*react_native_oss[a-z,_]*\\)?)\\)?:? #[0-9]+
+suppress_comment=\\(.\\|\n\\)*\\$FlowFixMe\\($\\|[^(]\\|(\\(>=0\\.\\(5[0-7]\\|[1-4][0-9]\\|[0-9]\\).[0-9]\\)? *\\(site=[a-z,_]*[react_native_oss|react_native_fb][a-z,_]*\\)?)\\)
+suppress_comment=\\(.\\|\n\\)*\\$FlowIssue\\((\\(>=0\\.\\(5[0-7]\\|[1-4][0-9]\\|[0-9]\\).[0-9]\\)? *\\(site=[a-z,_]*[react_native_oss|react_native_fb][a-z,_]*\\)?)\\)?:? #[0-9]+
 suppress_comment=\\(.\\|\n\\)*\\$FlowFixedInNextDeploy
 suppress_comment=\\(.\\|\n\\)*\\$FlowExpectedError
 
 unsafe.enable_getters_and_setters=true
 
 [version]
-^0.54.0
+^0.57.0

.github/PULL_REQUEST_TEMPLATE.md

@@ -9,8 +9,38 @@ Happy contributing!
 
 -->
 
+## Motivation
+
 (Write your motivation here.)
 
 ## Test Plan
 
 (Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)
+
+## Release Notes
+<!--
+Help reviewers and the release process by writing your own release notes
+
+**INTERNAL and MINOR tagged notes will not be included in the next version's final release notes.**
+
+  CATEGORY
+[----------]        TYPE
+[ CLI      ]   [-------------]      LOCATION
+[ DOCS     ]   [ BREAKING    ]   [-------------]
+[ GENERAl  ]   [ BUGFIX      ]   [-{Component}-]
+[ INTERNAL ]   [ ENHANCEMENT ]   [ {File}      ]
+[ IOS      ]   [ FEATURE     ]   [ {Directory} ]   |-----------|
+[ ANDROID  ]   [ MINOR       ]   [ {Framework} ] - | {Message} |
+[----------]   [-------------]   [-------------]   |-----------|
+
+[CATEGORY] [TYPE] [LOCATION] - MESSAGE
+
+ EXAMPLES:
+
+ [IOS] [BREAKING] [FlatList] - Change a thing that breaks other things
+ [ANDROID] [BUGFIX] [TextInput] - Did a thing to TextInput
+ [CLI] [FEATURE] [local-cli/info/info.js] - CLI easier to do things with
+ [DOCS] [BUGFIX] [GettingStarted.md] - Accidentally a thing/word
+ [GENERAL] [ENHANCEMENT] [Yoga] - Added new yoga thing/position
+ [INTERNAL] [FEATURE] [./scripts] - Added thing to script that nobody will see
+-->

.github/no-response.yml

@@ -0,0 +1,9 @@
+# Configuration for probot-no-response - https://github.com/probot/no-response
+
+# Number of days of inactivity before an Issue is closed for lack of response
+daysUntilClose: 14
+# Label requiring a response
+responseRequiredLabel: Needs more information
+# Comment to post when closing an Issue for lack of response. Set to `false` to disable
+closeComment: >
+  Closing this issue as more information is needed to debug this and we have not heard back from the author.

.github/stale.yml

@@ -0,0 +1,20 @@
+# Number of days of inactivity before an issue becomes stale
+daysUntilStale: 60
+# Number of days of inactivity before a stale issue is closed
+daysUntilClose: 7
+# Issues with these labels will never be considered stale
+exemptLabels:
+  - Good first issue
+  - For Discussion
+  - Core Team 
+# Label to use when marking an issue as stale
+staleLabel: Stale 
+# Comment to post when marking an issue as stale. Set to `false` to disable
+markComment: >
+  This issue has been automatically marked as stale because it has not had
+  recent activity. It will be closed if no further activity occurs.
+  Maybe the issue has been fixed in a recent release, or perhaps it is not affecting a lot of people.
+  If you think this issue should definitely remain open, please let us know why.
+  Thank you for your contributions.
+# Comment to post when closing a stale issue. Set to `false` to disable
+closeComment: false

CONTRIBUTING.md

@@ -13,7 +13,7 @@ There are many ways to contribute to React Native, and many of them do not invol
 
 * Simply start using React Native. Go through the [Getting Started](http://facebook.github.io/react-native/docs/getting-started.html) guide. Does everything work as expected? If not, we're always looking for improvements. Let us know by [opening an issue](http://facebook.github.io/react-native/docs/contributing.html#reporting-new-issues).
 * Look through the [open issues](https://github.com/facebook/react-native/issues). Provide workarounds, ask for clarification, or suggest labels. Help [triage issues](http://facebook.github.io/react-native/docs/contributing.html#triaging-issues-and-pull-requests).
-* If you find an issue you would like to fix, [open a pull request](http://facebook.github.io/react-native/docs/contributing.html#your-first-pull-request). Issues tagged as [_Good First Task_](https://github.com/facebook/react-native/labels/Good%20First%20Task) are a good place to get started.
+* If you find an issue you would like to fix, [open a pull request](http://facebook.github.io/react-native/docs/contributing.html#your-first-pull-request). Issues tagged as [_Good first issue_](https://github.com/facebook/react-native/labels/Good%20first%20issue) are a good place to get started.
 * Read through the [React Native docs](http://facebook.github.io/react-native/docs). If you find anything that is confusing or can be improved, you can make edits by clicking "Improve this page" at the bottom of most docs.
 * Browse [Stack Overflow](https://stackoverflow.com/questions/tagged/react-native) and answer questions. This will help you get familiarized with common pitfalls or misunderstandings, which can be useful when contributing updates to the documentation.
 * Take a look at the [features requested](https://react-native.canny.io/feature-requests) by others in the community and consider opening a pull request if you see something you want to work on.
@@ -92,16 +92,15 @@ If you're only fixing a bug, it's fine to submit a pull request right away but w
 
 Small pull requests are much easier to review and more likely to get merged. Make sure the PR does only one thing, otherwise please split it.
 
-**Before submitting a pull request**, please make sure the following is done:
+Please make sure the following is done when submitting a pull request:
 
 1. Fork [the repository](https://github.com/facebook/react-native) and create your branch from `master`.
 2. Add the copyright notice to the top of any new files you've added.
-3. Describe your [**test plan**](https://facebook.github.io/react-native/docs/contributing.html#test-plan) in your commit.
-4. Ensure [**tests pass**](https://facebook.github.io/react-native/docs/contributing.html#contrinuous-integration-tests) on both Travis and Circle CI.
-5. Make sure your code lints (`npm run lint`).
-6. If you haven't already, [sign the CLA](https://code.facebook.com/cla).
+3. Describe your [**test plan**](/react-native/docs/contributing.html#test-plan) in your pull request description. Make sure to [test your changes](/react-native/docs/testing.html)!
+4. Make sure your code lints (`npm run lint`).
+5. If you haven't already, [sign the CLA](https://code.facebook.com/cla).
 
-All pull requests should be opened against the `master` branch.
+All pull requests should be opened against the `master` branch. After opening your pull request, ensure [**all tests pass**](/react-native/docs/contributing.html#contrinuous-integration-tests) on Circle CI. If a test fails and you believe it is unrelated to your change, leave a comment on the pull request explaining why.
 
 > **Note:** It is not necessary to keep clicking `Merge master to your branch` on the PR page. You would want to merge master if there are conflicts or tests are failing. The Facebook-GitHub-Bot ultimately squashes all commits to a single one before merging your PR.
 
@@ -117,9 +116,8 @@ See [What is a Test Plan?](https://medium.com/@martinkonicek/what-is-a-test-plan
 
 #### Continuous integration tests
 
-Make sure all **tests pass** on both [Travis][travis] and [Circle CI][circle]. PRs that break tests are unlikely to be merged. Learn more about [testing your changes here](https://facebook.github.io/react-native/docs/testing.html).
+Make sure all **tests pass** on [Circle CI][circle]. PRs that break tests are unlikely to be merged. Learn more about [testing your changes here](/react-native/docs/testing.html).
 
-[travis]: https://travis-ci.org/facebook/react-native
 [circle]: http://circleci.com/gh/facebook/react-native
 
 #### Breaking changes
@@ -180,7 +178,7 @@ However, there are still some styles that the linter cannot pick up.
 #### JavaScript
 
 * Use semicolons;
-* `'use strict';`
+* ES6 standards
 * Prefer `'` over `"`
 * Do not use the optional parameters of `setTimeout` and `setInterval`
 * 80 character line length

ContainerShip/scripts/run-android-ci-instrumentation-tests.js

@@ -45,7 +45,7 @@ const test_opts = {
 
     OFFSET: argv.offset,
     COUNT: argv.count
-}
+};
 
 let max_test_class_length = Number.NEGATIVE_INFINITY;
 
@@ -85,14 +85,14 @@ if (test_opts.COUNT != null && test_opts.OFFSET != null) {
 }
 
 return async.mapSeries(testClasses, (clazz, callback) => {
-    if(clazz.length > max_test_class_length) {
+    if (clazz.length > max_test_class_length) {
         max_test_class_length = clazz.length;
     }
 
     return async.retry(test_opts.RETRIES, (retryCb) => {
         const test_process = child_process.spawn('./ContainerShip/scripts/run-instrumentation-tests-via-adb-shell.sh', [test_opts.PACKAGE, clazz], {
             stdio: 'inherit'
-        })
+        });
 
         const timeout = setTimeout(() => {
             test_process.kill();
@@ -106,7 +106,7 @@ return async.mapSeries(testClasses, (clazz, callback) => {
         test_process.on('exit', (code) => {
             clearTimeout(timeout);
 
-            if(code !== 0) {
+            if (code !== 0) {
                 return retryCb(new Error(`Process exited with code: ${code}`));
             }
 
@@ -138,16 +138,16 @@ function print_test_suite_results(results) {
     function pad_output(num_chars) {
         let i = 0;
 
-        while(i < num_chars) {
+        while (i < num_chars) {
             process.stdout.write(' ');
             i++;
         }
     }
     results.forEach((test) => {
-        if(test.status === 'success') {
+        if (test.status === 'success') {
             color = colors.GREEN;
             passing_suites++;
-        } else if(test.status === 'failure') {
+        } else if (test.status === 'failure') {
             color = colors.RED;
             failing_suites++;
         }

ContainerShip/scripts/run-instrumentation-tests-via-adb-shell.sh

@@ -29,7 +29,7 @@ def update():
   # prevent CircleCI from killing the process for inactivity
   while not done:
     time.sleep(5)
-    print "Running in background.  Waiting for 'adb' command reponse..."
+    print "Running in background.  Waiting for 'adb' command response..."
 
 t = threading.Thread(target=update)
 t.dameon = True

IntegrationTests/AsyncStorageTest.js

@@ -155,7 +155,7 @@ function testOptimizedMultiGet() {
   let keys = batch.map(([key, value]) => key);
   AsyncStorage.multiSet(batch, (err1) => {
     // yes, twice on purpose
-    ;[1, 2].forEach((i) => {
+    [1, 2].forEach((i) => {
       expectAsyncNoError(`${i} testOptimizedMultiGet/multiSet`, err1);
       AsyncStorage.multiGet(keys, (err2, result) => {
         expectAsyncNoError(`${i} testOptimizedMultiGet/multiGet`, err2);

IntegrationTests/ImageCachePolicyTest.js

@@ -48,7 +48,7 @@ class ImageCachePolicyTest extends React.Component<Props, $FlowFixMeState> {
     const results: Array<?boolean> = TESTS.map(x => nextState[x]);
 
     if (!results.includes(undefined)) {
-      const result: boolean = results.reduce((x,y) => x === y === true, true)
+      const result: boolean = results.reduce((x,y) => x === y === true, true);
       TestModule.markTestPassed(result);
     }
 

Libraries/ActionSheetIOS/ActionSheetIOS.js

@@ -29,6 +29,20 @@ var ActionSheetIOS = {
    *
    * The 'callback' function takes one parameter, the zero-based index
    * of the selected item.
+   *
+   * Minimal example:
+   * 
+   * ```
+   * ActionSheetIOS.showActionSheetWithOptions({
+   *   options: ['Remove', 'Cancel'],
+   *   destructiveButtonIndex: 1,
+   *   cancelButtonIndex: 0,
+   * },
+   * (buttonIndex) => {
+   *   if (buttonIndex === 1) { // destructive action }
+   * });
+   * ```
+   *
    */
   showActionSheetWithOptions(options: Object, callback: Function) {
     invariant(

Libraries/Animated/src/AnimatedImplementation.js

@@ -827,8 +827,11 @@ module.exports = {
   /**
   * Loops a given animation continuously, so that each time it reaches the
   * end, it resets and begins again from the start. Can specify number of
-  * times to loop using the key 'iterations' in the config. Will loop without
-  * blocking the UI thread if the child animation is set to 'useNativeDriver'.
+  * times to loop using the key `iterations` in the config. Will loop without
+  * blocking the UI thread if the child animation is set to `useNativeDriver: true`.
+  * In addition, loops can prevent `VirtualizedList`-based components from rendering
+  * more rows while the animation is running. You can pass `isInteraction: false` in the
+  * child animation config to fix this.
   */
   loop,
 

Libraries/Animated/src/Easing.js

@@ -162,11 +162,6 @@ class Easing {
    * times.
    *
    * http://easings.net/#easeInElastic
-   *
-   * Wolfram Plots:
-   *
-   * - http://tiny.cc/elastic_b_1 (bounciness = 1, default)
-   * - http://tiny.cc/elastic_b_3 (bounciness = 3)
    */
   static elastic(bounciness: number = 1): (t: number) => number {
     const p = bounciness * Math.PI;