Skip to content

Commit

Permalink
Update documentation for Modal's prop animationType
Browse files Browse the repository at this point in the history
Summary:
I was using Modal component and I didn't knew what was the default for animationType prop. After reading the code, I saw that it was `none`.

I did not tell that the "default" is `slide` if animated is set to `true`, because it is not a default but an implementation of `animated` prop effect and because of the deprecation of `animated`.

Thanks.
Closes #13196

Differential Revision: D4795765

Pulled By: hramos

fbshipit-source-id: 25d62ac7eeb20fc5557918c3d75709f44f5d4972
  • Loading branch information
elieteyssedou authored and facebook-github-bot committed Mar 29, 2017
1 parent c311096 commit 56a4538
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions Libraries/Modal/Modal.js
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,8 @@ class Modal extends React.Component {
* - `slide` slides in from the bottom
* - `fade` fades into view
* - `none` appears without an animation
*
* Default is set to `none`.
*/
animationType: PropTypes.oneOf(['none', 'slide', 'fade']),
/**
Expand Down

0 comments on commit 56a4538

Please sign in to comment.