Skip to content

Commit

Permalink
Remove last tasks.creating invocation inside hermes-engine (#48739)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: #48739

Follow-up to #48603
I realized there is one last `tasks.creating` invocation inside `hermes-engine` that needs migration. This fixes it.

Changelog:
[Internal] [Changed] -

Reviewed By: alanleedev

Differential Revision: D68276984

fbshipit-source-id: d58cf64cf41c7943464f15d12c7a04c3cc43ec7d
  • Loading branch information
cortinico authored and facebook-github-bot committed Jan 16, 2025
1 parent f30c46e commit 40c18e1
Showing 1 changed file with 4 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -90,21 +90,22 @@ val prefabHeadersDir = File("$buildDir/prefab-headers")
// We inject the JSI directory used inside the Hermes build with the -DJSI_DIR config.
val jsiDir = File(reactNativeRootDir, "ReactCommon/jsi")

val downloadHermesDest = File(downloadsDir, "hermes.tar.gz")
val downloadHermes by
tasks.creating(Download::class) {
tasks.registering(Download::class) {
src("https://github.com/facebook/hermes/tarball/${hermesVersion}")
onlyIfModified(true)
overwrite(true)
quiet(true)
useETag("all")
retries(5)
dest(File(downloadsDir, "hermes.tar.gz"))
dest(downloadHermesDest)
}

val unzipHermes by
tasks.registering(Copy::class) {
dependsOn(downloadHermes)
from(tarTree(downloadHermes.dest)) {
from(tarTree(downloadHermesDest)) {
eachFile {
// We flatten the unzip as the tarball contains a `facebook-hermes-<SHA>`
// folder at the top level.
Expand Down

0 comments on commit 40c18e1

Please sign in to comment.