Fabric: AccessibilityProps::testId mapped to testID and implement…

…ed for iOS

Summary:
This should make `testID` prop work as it works in pre-Fabric renderer on iOS.
On Android it should already work fine.

Changelog: [Internal] Fabric-specific internal change.

Reviewed By: JoshuaGross

Differential Revision: D25524890

fbshipit-source-id: 3f25eb427d4449abaab790099546be18ae573f98

React/Fabric/Mounting/ComponentViews/View/RCTViewComponentView.mm

@@ -248,6 +248,11 @@ - (void)updateProps:(Props::Shared const &)props oldProps:(Props::Shared const &
 #endif
   }
 
+  // `testId`
+  if (oldViewProps.testId != newViewProps.testId) {
+    self.accessibilityIdentifier = RCTNSStringFromString(newViewProps.testId);
+  }
+
   _needsInvalidateLayer = _needsInvalidateLayer || needsInvalidateLayer;
 
   _props = std::static_pointer_cast<ViewProps const>(props);

ReactCommon/react/renderer/components/view/AccessibilityProps.cpp

@@ -88,7 +88,7 @@ AccessibilityProps::AccessibilityProps(
           "importantForAccessibility",
           sourceProps.importantForAccessibility,
           ImportantForAccessibility::Auto)),
-      testId(convertRawProp(rawProps, "testId", sourceProps.testId, "")) {}
+      testId(convertRawProp(rawProps, "testID", sourceProps.testId, "")) {}
 
 #pragma mark - DebugStringConvertible
 

ReactCommon/react/renderer/components/view/ViewShadowNode.cpp

@@ -54,7 +54,8 @@ void ViewShadowNode::initialize() noexcept {
 
   bool formsView = isColorMeaningful(viewProps.backgroundColor) ||
       isColorMeaningful(viewProps.foregroundColor) ||
-      !(viewProps.yogaStyle.border() == YGStyle::Edges{});
+      !(viewProps.yogaStyle.border() == YGStyle::Edges{}) ||
+      !viewProps.testId.empty();
 
   formsView = formsView || formsStackingContext;
 

ReactCommon/react/renderer/templateprocessor/tests/UITemplateProcessorTest.cpp

@@ -89,8 +89,8 @@ TEST(UITemplateProcessorTest, testSimpleBytecode) {
   auto nativeModuleRegistry = buildNativeModuleRegistry();
 
   auto bytecode = R"delim({"version":0.1,"commands":[
-    ["createNode",2,"RCTView",-1,{"opacity": 0.5, "testId": "root"}],
-    ["createNode",4,"RCTView",2,{"testId": "child"}],
+    ["createNode",2,"RCTView",-1,{"opacity": 0.5, "testID": "root"}],
+    ["createNode",4,"RCTView",2,{"testID": "child"}],
     ["returnRoot",2]
   ]})delim";
 
@@ -124,11 +124,11 @@ TEST(UITemplateProcessorTest, testConditionalBytecode) {
   auto nativeModuleRegistry = buildNativeModuleRegistry();
 
   auto bytecode = R"delim({"version":0.1,"commands":[
-    ["createNode",2,"RCTView",-1,{"testId": "root"}],
+    ["createNode",2,"RCTView",-1,{"testID": "root"}],
     ["loadNativeBool",1,"MobileConfig","getBool",["qe:simple_test"]],
     ["conditional",1,
-      [["createNode",4,"RCTView",2,{"testId": "cond_true"}]],
-      [["createNode",4,"RCTView",2,{"testId": "cond_false"}]]
+      [["createNode",4,"RCTView",2,{"testID": "cond_true"}]],
+      [["createNode",4,"RCTView",2,{"testID": "cond_false"}]]
     ],
     ["returnRoot",2]
   ]})delim";