Skip to content

Commit

Permalink
Remove vendored proguard annotation
Browse files Browse the repository at this point in the history
Summary:
There have been multiple complaints about combining RN with various
other FB libraries, including Litho, because of bundled dependencies
that can't be deduplicated by Gradle.

This is one of three current conflicts:

1) Proguard annotations (this PR)
2) Yoga
3) fbjni

While the Yoga group name doesn't make a massive amount of sense
it was the easiest existing package to use and since we don't
have a better namespace for this, we might as well use this.

A similar change to Litho is landing right now.

Test Plan:
```
yarn
./gradlew :RNTester:android:app:assembleDebug
```
  • Loading branch information
passy committed Aug 15, 2019
1 parent 0057cc9 commit 094ebcc
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 22 deletions.
1 change: 1 addition & 0 deletions ReactAndroid/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -356,6 +356,7 @@ android {

dependencies {
api("com.facebook.infer.annotation:infer-annotation:0.11.2")
api("com.facebook.yoga:proguard-annotations:1.14.1")
api("javax.inject:javax.inject:1")
api("androidx.appcompat:appcompat:1.0.2")
api("com.facebook.fresco:fresco:${FRESCO_VERSION}")
Expand Down

This file was deleted.

0 comments on commit 094ebcc

Please sign in to comment.