add cmd+opt+ctrl+D to globally invoke dev menu for Android

Reviewed By: frantic Differential Revision: D5280788 fbshipit-source-id: ce11d122ee17a2ba8d8aa2e91fc6639610791577
facebook · Jun 21, 2017 · 01adc71 · 01adc71
1 parent a2b0ee0
commit 01adc71
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 0 deletions.
diff --git a/ReactAndroid/src/main/java/com/facebook/react/devsupport/DevServerHelper.java b/ReactAndroid/src/main/java/com/facebook/react/devsupport/DevServerHelper.java
@@ -98,6 +98,7 @@ public interface OnServerContentChangeListener {
 
   public interface PackagerCommandListener {
     void onPackagerReloadCommand();
+    void onPackagerDevMenuCommand();
     void onCaptureHeapCommand(final Responder responder);
     void onPokeSamplingProfilerCommand(final Responder responder);
   }
@@ -145,6 +146,12 @@ public void onNotification(@Nullable Object params) {
             commandListener.onPackagerReloadCommand();
           }
         });
+        handlers.put("devMenu", new NotificationOnlyHandler() {
+          @Override
+          public void onNotification(@Nullable Object params) {
+            commandListener.onPackagerDevMenuCommand();
+          }
+        });
         handlers.put("captureHeap", new RequestOnlyHandler() {
           @Override
           public void onRequest(@Nullable Object params, Responder responder) {

diff --git a/ReactAndroid/src/main/java/com/facebook/react/devsupport/DevSupportManagerImpl.java b/ReactAndroid/src/main/java/com/facebook/react/devsupport/DevSupportManagerImpl.java
@@ -682,6 +682,16 @@ public void run() {
     });
   }
 
+  @Override
+  public void onPackagerDevMenuCommand() {
+    UiThreadUtil.runOnUiThread(new Runnable() {
+      @Override
+      public void run() {
+        showDevOptionsDialog();
+      }
+    });
+  }
+
   @Override
   public void onCaptureHeapCommand(final Responder responder) {
     UiThreadUtil.runOnUiThread(new Runnable() {