Skip to content

Commit

Permalink
Build fast_float from source on Ubuntu < 24.04
Browse files Browse the repository at this point in the history
Summary:
libfast-float-dev only exists on Ubuntu 24.04 and newer, causing build failures on older releases.

X-link: facebook/folly#2283

Reviewed By: yfeldblum

Differential Revision: D61622213

Pulled By: Orvid

fbshipit-source-id: ea683431874d711f8e693b2dd6607cb36f5d8adf
  • Loading branch information
mszabo-wikia authored and facebook-github-bot committed Aug 22, 2024
1 parent 8cc4152 commit 39023f9
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 1 deletion.
2 changes: 1 addition & 1 deletion build/fbcode_builder/manifests/fast_float
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ subdir = fast_float-2.0.0
FASTFLOAT_TEST = OFF
FASTFLOAT_SANITIZE = OFF

[debs]
[debs.not(all(distro=ubuntu,any(distro_vers="18.04",distro_vers="20.04",distro_vers="22.04")))]
libfast-float-dev

[rpms.distro=fedora]
Expand Down
4 changes: 4 additions & 0 deletions third-party/folly/src/.github/workflows/getdeps_linux.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,8 @@ jobs:
run: python3 build/fbcode_builder/getdeps.py --allow-system-packages fetch --no-tests cmake
- name: Fetch double-conversion
run: python3 build/fbcode_builder/getdeps.py --allow-system-packages fetch --no-tests double-conversion
- name: Fetch fast_float
run: python3 build/fbcode_builder/getdeps.py --allow-system-packages fetch --no-tests fast_float
- name: Fetch fmt
run: python3 build/fbcode_builder/getdeps.py --allow-system-packages fetch --no-tests fmt
- name: Fetch gflags
Expand Down Expand Up @@ -80,6 +82,8 @@ jobs:
run: python3 build/fbcode_builder/getdeps.py --allow-system-packages build --free-up-disk --no-tests cmake
- name: Build double-conversion
run: python3 build/fbcode_builder/getdeps.py --allow-system-packages build --free-up-disk --no-tests double-conversion
- name: Build fast_float
run: python3 build/fbcode_builder/getdeps.py --allow-system-packages build --free-up-disk --no-tests fast_float
- name: Build fmt
run: python3 build/fbcode_builder/getdeps.py --allow-system-packages build --free-up-disk --no-tests fmt
- name: Build gflags
Expand Down
4 changes: 4 additions & 0 deletions third-party/folly/src/.github/workflows/getdeps_mac.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,8 @@ jobs:
run: python3 build/fbcode_builder/getdeps.py --allow-system-packages fetch --no-tests cmake
- name: Fetch double-conversion
run: python3 build/fbcode_builder/getdeps.py --allow-system-packages fetch --no-tests double-conversion
- name: Fetch fast_float
run: python3 build/fbcode_builder/getdeps.py --allow-system-packages fetch --no-tests fast_float
- name: Fetch fmt
run: python3 build/fbcode_builder/getdeps.py --allow-system-packages fetch --no-tests fmt
- name: Fetch gflags
Expand Down Expand Up @@ -74,6 +76,8 @@ jobs:
run: python3 build/fbcode_builder/getdeps.py --allow-system-packages build --free-up-disk --no-tests cmake
- name: Build double-conversion
run: python3 build/fbcode_builder/getdeps.py --allow-system-packages build --free-up-disk --no-tests double-conversion
- name: Build fast_float
run: python3 build/fbcode_builder/getdeps.py --allow-system-packages build --free-up-disk --no-tests fast_float
- name: Build fmt
run: python3 build/fbcode_builder/getdeps.py --allow-system-packages build --free-up-disk --no-tests fmt
- name: Build gflags
Expand Down
4 changes: 4 additions & 0 deletions third-party/folly/src/.github/workflows/getdeps_windows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,8 @@ jobs:
run: python build/fbcode_builder/getdeps.py fetch --no-tests cmake
- name: Fetch double-conversion
run: python build/fbcode_builder/getdeps.py fetch --no-tests double-conversion
- name: Fetch fast_float
run: python build/fbcode_builder/getdeps.py fetch --no-tests fast_float
- name: Fetch fmt
run: python build/fbcode_builder/getdeps.py fetch --no-tests fmt
- name: Fetch gflags
Expand Down Expand Up @@ -69,6 +71,8 @@ jobs:
run: python build/fbcode_builder/getdeps.py build --free-up-disk --no-tests cmake
- name: Build double-conversion
run: python build/fbcode_builder/getdeps.py build --free-up-disk --no-tests double-conversion
- name: Build fast_float
run: python build/fbcode_builder/getdeps.py build --free-up-disk --no-tests fast_float
- name: Build fmt
run: python build/fbcode_builder/getdeps.py build --free-up-disk --no-tests fmt
- name: Build gflags
Expand Down

0 comments on commit 39023f9

Please sign in to comment.