Remove user declared default destructor

Summary: General rule about dtors is not to have user declared dtors if you can. Adding user declared dtors can have some unwanted implications. So let's follow rule zero. https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Rc-zero Reviewed By: spikeh Differential Revision: D54668176 fbshipit-source-id: 964869d873f9dc6173dd6cbe909bb11683f7b478
facebook · Mar 9, 2024 · 66a7788 · 66a7788
1 parent 1d93a8c
commit 66a7788
Showing 1 changed file with 0 additions and 27 deletions.
diff --git a/folly/experimental/io/IoUringBackend.h b/folly/experimental/io/IoUringBackend.h
@@ -496,7 +496,6 @@ class IoUringBackend : public EventBaseBackendBase {
         bool poolAlloc = false,
         bool persist = false)
         : backend_(backend), poolAlloc_(poolAlloc), persist_(persist) {}
-    virtual ~IoSqe() override = default;
 
     void callback(int res, uint32_t flags) noexcept override {
       backendCb_(backend_, this, res, flags);
@@ -762,8 +761,6 @@ class IoUringBackend : public EventBaseBackendBase {
     FileOpIoSqe(IoUringBackend* backend, int fd, FileOpCallback&& cb)
         : IoSqe(backend, false), fd_(fd), cb_(std::move(cb)) {}
 
-    ~FileOpIoSqe() override = default;
-
     void processActive() override { cb_(res_); }
 
     int fd_{-1};
@@ -790,8 +787,6 @@ class IoUringBackend : public EventBaseBackendBase {
         FileOpCallback&& cb)
         : FileOpIoSqe(backend, fd, std::move(cb)), iov_(iov), offset_(offset) {}
 
-    ~ReadWriteIoSqe() override = default;
-
     void processActive() override { cb_(res_); }
 
     static constexpr size_t kNumInlineIoVec = 4;
@@ -802,16 +797,13 @@ class IoUringBackend : public EventBaseBackendBase {
   struct ReadIoSqe : public ReadWriteIoSqe {
     using ReadWriteIoSqe::ReadWriteIoSqe;
 
-    ~ReadIoSqe() override = default;
-
     void processSubmit(struct io_uring_sqe* sqe) noexcept override {
       prepRead(sqe, fd_, iov_.data(), offset_, false);
     }
   };
 
   struct WriteIoSqe : public ReadWriteIoSqe {
     using ReadWriteIoSqe::ReadWriteIoSqe;
-    ~WriteIoSqe() override = default;
 
     void processSubmit(struct io_uring_sqe* sqe) noexcept override {
       prepWrite(sqe, fd_, iov_.data(), offset_, false);
@@ -821,8 +813,6 @@ class IoUringBackend : public EventBaseBackendBase {
   struct ReadvIoSqe : public ReadWriteIoSqe {
     using ReadWriteIoSqe::ReadWriteIoSqe;
 
-    ~ReadvIoSqe() override = default;
-
     void processSubmit(struct io_uring_sqe* sqe) noexcept override {
       ::io_uring_prep_readv(
           sqe, fd_, iov_.data(), (unsigned int)iov_.size(), offset_);
@@ -832,7 +822,6 @@ class IoUringBackend : public EventBaseBackendBase {
 
   struct WritevIoSqe : public ReadWriteIoSqe {
     using ReadWriteIoSqe::ReadWriteIoSqe;
-    ~WritevIoSqe() override = default;
 
     void processSubmit(struct io_uring_sqe* sqe) noexcept override {
       ::io_uring_prep_writev(
@@ -851,8 +840,6 @@ class IoUringBackend : public EventBaseBackendBase {
         IoUringBackend* backend, int fd, FSyncFlags flags, FileOpCallback&& cb)
         : FileOpIoSqe(backend, fd, std::move(cb)), flags_(flags) {}
 
-    ~FSyncIoSqe() override = default;
-
     void processSubmit(struct io_uring_sqe* sqe) noexcept override {
       unsigned int fsyncFlags = 0;
       switch (flags_) {
@@ -884,8 +871,6 @@ class IoUringBackend : public EventBaseBackendBase {
           flags_(flags),
           mode_(mode) {}
 
-    ~FOpenAtIoSqe() override = default;
-
     void processSubmit(struct io_uring_sqe* sqe) noexcept override {
       ::io_uring_prep_openat(sqe, fd_, path_.c_str(), flags_, mode_);
       ::io_uring_sqe_set_data(sqe, this);
@@ -905,8 +890,6 @@ class IoUringBackend : public EventBaseBackendBase {
         FileOpCallback&& cb)
         : FileOpIoSqe(backend, dfd, std::move(cb)), path_(path), how_(*how) {}
 
-    ~FOpenAt2IoSqe() override = default;
-
     void processSubmit(struct io_uring_sqe* sqe) noexcept override {
       ::io_uring_prep_openat2(sqe, fd_, path_.c_str(), &how_);
       ::io_uring_sqe_set_data(sqe, this);
@@ -919,8 +902,6 @@ class IoUringBackend : public EventBaseBackendBase {
   struct FCloseIoSqe : public FileOpIoSqe {
     using FileOpIoSqe::FileOpIoSqe;
 
-    ~FCloseIoSqe() override = default;
-
     void processSubmit(struct io_uring_sqe* sqe) noexcept override {
       ::io_uring_prep_close(sqe, fd_);
       ::io_uring_sqe_set_data(sqe, this);
@@ -942,8 +923,6 @@ class IoUringBackend : public EventBaseBackendBase {
           mask_(mask),
           statxbuf_(statxbuf) {}
 
-    ~FStatxIoSqe() override = default;
-
     void processSubmit(struct io_uring_sqe* sqe) noexcept override {
       ::io_uring_prep_statx(sqe, fd_, path_, flags_, mask_, statxbuf_);
       ::io_uring_sqe_set_data(sqe, this);
@@ -968,8 +947,6 @@ class IoUringBackend : public EventBaseBackendBase {
           offset_(offset),
           len_(len) {}
 
-    ~FAllocateIoSqe() override = default;
-
     void processSubmit(struct io_uring_sqe* sqe) noexcept override {
       ::io_uring_prep_fallocate(sqe, fd_, mode_, offset_, len_);
       ::io_uring_sqe_set_data(sqe, this);
@@ -989,8 +966,6 @@ class IoUringBackend : public EventBaseBackendBase {
         FileOpCallback&& cb)
         : FileOpIoSqe(backend, fd, std::move(cb)), msg_(msg), flags_(flags) {}
 
-    ~SendmsgIoSqe() override = default;
-
     void processSubmit(struct io_uring_sqe* sqe) noexcept override {
       ::io_uring_prep_sendmsg(sqe, fd_, msg_, flags_);
       ::io_uring_sqe_set_data(sqe, this);
@@ -1009,8 +984,6 @@ class IoUringBackend : public EventBaseBackendBase {
         FileOpCallback&& cb)
         : FileOpIoSqe(backend, fd, std::move(cb)), msg_(msg), flags_(flags) {}
 
-    ~RecvmsgIoSqe() override = default;
-
     void processSubmit(struct io_uring_sqe* sqe) noexcept override {
       ::io_uring_prep_recvmsg(sqe, fd_, msg_, flags_);
       ::io_uring_sqe_set_data(sqe, this);