Defer cpp2 union move compilations #617
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The move accessors in generated cpp2 thrift code suffer from an eager compilation issue similar to the one reported for union setters in facebook#508, when compiling with clang / libstdc++ (https://godbolt.org/z/KGr9cM5n5). As a fix, make these accessors templated, like the field ref accessors, to defer compilation.
|
facebook/folly#2283 should address the CI error. |
|
@vitaut has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Merged, thanks! |
|
Thanks for the review! |
facebook-github-bot
pushed a commit
to facebook/hhvm
that referenced
this pull request
Sep 11, 2024
Summary: The move accessors in generated cpp2 thrift code suffer from an eager compilation issue similar to the one reported for union setters in facebook/fbthrift#508, when compiling with clang / libstdc++ (https://godbolt.org/z/KGr9cM5n5). As a fix, make these accessors templated, like the field ref accessors, to defer compilation. X-link: facebook/fbthrift#617 Reviewed By: thedavekwon Differential Revision: D61673446 Pulled By: vitaut fbshipit-source-id: fb37f4046207fc19f2d2a438b5b565e686987930
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The move accessors in generated cpp2 thrift code suffer from an eager compilation issue similar to the one reported for union setters in #508, when compiling with clang / libstdc++
(https://godbolt.org/z/KGr9cM5n5).
As a fix, make these accessors templated, like the field ref accessors, to defer compilation.