release/3.3.3 #2873
Open
release/3.3.3 #2873
+98
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iodic
reviewed
Feb 7, 2025
includes/fbproduct.php
Outdated
| @@ -726,6 +726,8 @@ public function prepare_product( $retailer_id = null, $type_to_prepare_for = sel | |||
|
|
|||
| $custom_fields = $this->get_facebook_specific_fields(); | |||
|
|
|||
| $custom_fields = $this->get_facebook_specific_fields(); | |||
There was a problem hiding this comment.
Looks like this line was duplicated in the previous release, can we delete it?
iodic
requested changes
Feb 7, 2025
iodic
approved these changes
Feb 10, 2025
|
@vahidkay-meta has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
e0acd7a to
d85b0d0
Compare
|
@vahidkay-meta has updated the pull request. You must reimport the pull request before landing. |
…sion endpoint (#2844) Summary: **Problem:** 1. The Delete Permission User API only removed Meta connection assets from the WooCommerce database, leaving asset-related data enabled on Meta surfaces. 2. If a user disconnected the connection before uninstalling assets from Meta surfaces using Managed Connection; the UI for Managed Connection was also removed, making it difficult for users to uninstall this feature from Meta surface. **Solution:** 1. Replaced the Delete Permission User API with the recommended Delete FBE Connection endpoint, which uninstalls assets from Meta surfaces and removes their permissions. 2. Removed the Managed Connection UI button for uninstalling FBE from Meta surfaces, as the Delete Connection endpoint now handles this functionality. **Before:** <img width="784" alt="image" src="https://github.com/user-attachments/assets/76bf6364-2af8-4657-a043-8e79aaff99c6"> **After:** <img width="803" alt="image" src="https://github.com/user-attachments/assets/45e7ebc8-4a74-4589-a9e3-0e4fff1f4f20">  <img width="797" alt="image" src="https://github.com/user-attachments/assets/f4d215b0-0959-4ee8-8347-16c64afe3460"> 1. Run new tests: `./vendor/bin/phpunit --filter test_delete_mbe_connection_deletes_user_permission_request` 2. Run all tests : `npm run test:php` 3. Lint: `./vendor/bin/phpcs` 4. Manual testing: I have tested new Disconnect UI flow; it uninstall FBE connection from WooCommerce as well as from Meta surface - **Removed:** Delete Permission User API - **Added:** Delete FBE Connection endpoint to uninstall assets from Meta surfaces and remove permissions - **Removed:** Managed Connection UI button for uninstalling FBE from Meta surfaces (now handled by Delete Connection endpoint) Pull Request resolved: #2844 Reviewed By: halilozanakgul Differential Revision: D68972713 Pulled By: atuld123 fbshipit-source-id: b19ee8351b4852c69192449f9af2644960a55307 parent 4be2987 author github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> 1738833933 +0000 committer Vahid Kaykhaei <vahidkay@meta.com> 1739267285 +0100 Start `release/3.3.3`. Start `release/3.3.1`. Updated the plugin version to 3.3.3 Updated the stable tag to 3.3.3 Fixed the version nr in fb-for-woo.php Fixed a review comment
d85b0d0 to
9075f97
Compare
|
@vahidkay-meta has updated the pull request. You must reimport the pull request before landing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch contains the release version updates