Fix Product Syncing via Feeds #2841
Conversation
| } | ||
|
|
||
| // Step 2 - Query feeds data from Meta and filter the right one | ||
| $feed_id = self::query_and_filter_integration_feed_id(); |
There was a problem hiding this comment.
This could throw an error that is currently not being caught
| continue; | ||
| } | ||
|
|
||
| $woo_feed_name_option_1 = self::FEED_NAME; |
There was a problem hiding this comment.
suggest factor out to private function named something like private function pattern_match_feed_names()
| private function query_and_filter_integration_feed_id() { | ||
| $catalog_id = facebook_for_woocommerce()->get_integration()->get_product_catalog_id(); | ||
| if ( '' === $catalog_id ) { | ||
| throw new Error( 'No catalog ID' ); |
There was a problem hiding this comment.
not being caught in retrieve_or_create_integrationFeed_id()
| WC_Facebookcommerce_Utils::log( 'Feed: retrieve_integration_feed_id(): feed_id = '.$feed_id.', created a new feed via Meta API.'); | ||
| return $feed_id; | ||
| } | ||
|
|
There was a problem hiding this comment.
Maybe we can throw an error or log here. Something like 'couldn't create feed'
| }; | ||
| add_filter( 'pre_http_request', $response, 10, 3 ); | ||
|
|
||
| $this->api->create_upload( $product_feed_id, $data ); |
There was a problem hiding this comment.
Shouldn't there be an assert here?
| private function validate_feed_exists($feed_id) { | ||
| $catalog_id = facebook_for_woocommerce()->get_integration()->get_product_catalog_id(); | ||
| if ( '' === $catalog_id ) { | ||
| throw new Error( 'No catalog ID' ); |
There was a problem hiding this comment.
Are the errors stored in the logs or was it a conscious decision to not add any logs here
| * | ||
| * @internal | ||
| */ | ||
| private function query_and_filter_integration_feed_id() { |
There was a problem hiding this comment.
This method seems like a lot of logic
Can we have it broken out a bit
| @@ -715,4 +715,63 @@ public function test_read_feeds_creates_read_feeds_request() { | |||
| $response->data | |||
| ); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Can you add a test to check unhappy path
If errors are thrown or logs are generated
Changes proposed in this Pull Request:
The current state of the product syncing via Feeds is broken - while plugin code base has business logic to generate feed file daily and serve the feed file on request, there is no logic for triggering a feed one time upload.
In this PR I am suggesting the following fixes to unblock product sync via feeds:
Trigger a daily feed upload sessions.
Update Feed file content by:
GTINto the feed filequantity_to_sell_on_facebookto the feed fileDetailed test instructions:
A. Run new tests:
./vendor/bin/phpunit --filter ApiTest./vendor/bin/phpunit --filter fbproductTestB. Run all tests:
npm run test:phpChangelog entry
Fix - Fixed feeds by requesting a feed file upload session after feed file is generated and added missing new fields to the feed file.