Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(blog): add LastUpdateAuthor & LastUpdateTime #9912
feat(blog): add LastUpdateAuthor & LastUpdateTime #9912
Changes from 2 commits
5ba18f3
5967a6f
dc305e3
6f098d8
8b19677
4db29f9
fb2a3b6
7130546
2965359
6331811
3a88750
87fcdf0
5dc4c04
e0ac624
7bb0310
ba1d743
b0a22d6
92ef13f
f6df255
7636376
cc70ae1
cf8a9ad
173d922
4602164
40d5163
6754b74
a2b9a1e
64644c4
9e0c233
e72b315
c60ae69
6169d68
9e5f53e
b5f5617
7801a60
fad3994
8485d21
bd59b1b
0d5a109
daf88ab
a794d06
7b8cabb
1d28fa4
718c7c3
cb7a7ee
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this is the historical message, but honestly, I doubt users will understand it 😅
Not sure mentioning
FileChange
is super useful, we just need users to know they should provide a date or an author attribute.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As author seems to be only a string I wonder removing
author key or an author object
(with a key and/or name)
So it would be something like this :
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you mislead blog post authors and last update author: those are different concepts
https://docusaurus.io/docs/api/plugins/@docusaurus/plugin-content-blog#authors
Blog post authors (not just a single one) can be objects, strings (keys)
Only the last update author is just a string, so your new validation error message proposal is not good.
Not good either, the last update is not a "date", but an object that can have either (or both) a date attribute (
Date | string
) and an author (string
) attribute.The message doesn't have to explain the types IMHO, just mention that the overall object shape is wrong and valid attribute names. Yaml will auto-convert strings to Dates depending on the format so mentioning it accept both Date + string is kind of overkill.