Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(create): run async tasks concurrently #8080

Merged
merged 7 commits into from
Sep 11, 2022

Conversation

sanjaiyan-dev
Copy link
Contributor

Improving the performance by running the independent async functions in parallel ✈️.

Sorry if I made any mistakes :(

Comment on lines 124 to 125
"react": "^16.8.4 || ^17.0.0 || ^18.0.0-0",
"react-dom": "^16.8.4 || ^17.0.0 || ^18.0.0-0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert the unrelated changes.

@netlify
Copy link

netlify bot commented Sep 11, 2022

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit 71fa9ae
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/631d46784c3cfa000c5082e2
😎 Deploy Preview https://deploy-preview-8080--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Sep 11, 2022

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 88 🟢 98 🟢 100 🟢 100 🟠 80 Report
/docs/installation 🟠 73 🟢 100 🟢 100 🟢 100 🟢 90 Report

@sanjaiyan-dev sanjaiyan-dev requested review from Josh-Cena and removed request for slorber and lex111 September 11, 2022 02:12
@Josh-Cena Josh-Cena changed the title Improve performance by compressing in parallel ✈️ perf(create): run async tasks concurrently Sep 11, 2022
@Josh-Cena Josh-Cena added the domain: performance Related to bundle size or perf optimization label Sep 11, 2022
Copy link
Collaborator

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Josh-Cena Josh-Cena merged commit 0a87116 into facebook:main Sep 11, 2022
@sanjaiyan-dev sanjaiyan-dev deleted the sanjaiyan-parallel-async branch September 11, 2022 03:29
@slorber slorber added the to backport This PR is planned to be backported to a stable version of Docusaurus label Sep 28, 2022
slorber pushed a commit that referenced this pull request Oct 28, 2022
* Adding incremental support for React 18 🚀

* parallel

* revert react 18

* revert lint

* end line

* Update packages/create-docusaurus/src/index.ts

Co-authored-by: Joshua Chen <sidachen2003@gmail.com>
@slorber slorber added backported This PR has been backported to a stable version of Docusaurus and removed to backport This PR is planned to be backported to a stable version of Docusaurus labels Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported This PR has been backported to a stable version of Docusaurus CLA Signed Signed Facebook CLA domain: performance Related to bundle size or perf optimization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants