Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(v2): Add new showcase user #4649

Merged
merged 3 commits into from
Apr 20, 2021
Merged

docs(v2): Add new showcase user #4649

merged 3 commits into from
Apr 20, 2021

Conversation

JeremyDolle
Copy link
Contributor

No description provided.

@facebook-github-bot
Copy link
Contributor

Hi @JeremyDolle!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@netlify
Copy link

netlify bot commented Apr 20, 2021

[V2]

Built with commit fcc3316

https://deploy-preview-4649--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Apr 20, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 68
🟢 Accessibility 96
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-4649--docusaurus-2.netlify.app/

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Apr 20, 2021
@slorber slorber changed the title Add new showcase user docs(v2): Add new showcase user Apr 20, 2021
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Apr 20, 2021
@slorber
Copy link
Collaborator

slorber commented Apr 20, 2021

thanks, lgtm :)

didn't know this project, is there a blog post for the v3 or something?

@netlify
Copy link

netlify bot commented Apr 20, 2021

[V1]

Built with commit fcc3316

https://deploy-preview-4649--docusaurus-1.netlify.app

@slorber slorber merged commit ca9752f into facebook:master Apr 20, 2021
@JeremyDolle
Copy link
Contributor Author

thanks, lgtm :)

didn't know this project, is there a blog post for the v3 or something?

I just make a reddit post for now. Do you think I should detail the V3 release in a blog post ? What kind of information do you want to find about a release blog post ? I'm interested 😀

@slorber
Copy link
Collaborator

slorber commented Apr 20, 2021

@JeremyDolle I run a french React newsletter (https://reacthebdo.fr/) and Twitter news threads (https://twitter.com/sebastienlorber/status/1384171018831335432) and would be happy to include it if there was a more detailed post presenting the project.

For each major you should present the current state, what's new etc, that helps marked the project. I basically want a TLDR of what your project is about, and how it is different from alternatives like Ignite etc (without having to read your whole doc).

You can add a blog to the docusaurus site ;)

@JeremyDolle
Copy link
Contributor Author

@slorber Yes I am French and I follow your newsletter 🇫🇷 😉 !! So I will do a blog post to detail what's in the box and send you the url on discord or twitter as you prefer ! See you soon 👋

@slorber
Copy link
Collaborator

slorber commented Apr 20, 2021

thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants