fix(v2): center align content if no sidebar exists #4621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 599 kB ℹ️ View Unchanged
|
|
[V2] Built with commit e81be92 |
|
[V1] Built with commit e81be92 |
|
Thanks, that's an improvement compared to the current state so I'm going to merge Still feels it's a bit weird to have the text not totally centered. We can improve this later, I'll try to have some feedbacks from a designer.
|
|
its still not totally center aligned, how could that be done? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #4512
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
See To Reproduce section in the issue above.
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)