-
-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(v2): Add "PptxGenJS" to showcase #4602
Conversation
[V2] Built without sensitive environment variables with commit 05314d3 |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-4602--docusaurus-2.netlify.app/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, almost LGTM, just the source is targeting the gh-pages deployment in place of your site's source code
website/src/data/users.js
Outdated
description: 'PowerPoint JavaScript Library', | ||
preview: require('./showcase/pptxgenjs.png'), | ||
website: 'https://gitbrent.github.io/PptxGenJS/', | ||
source: 'https://github.com/gitbrent/PptxGenJS/tree/gh-pages', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you change this source url to the repo where the Docusaurus site sources are? (I mean, not the built HTML files)
[V1] Built with commit d0fed96 |
[V1] Built with commit 0bf30ba |
Motivation
Adding new site to showcase.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Run yarn run start:v2 and check that the page http://localhost:3000/showcase is rendered properly.
Related PRs
No