-
-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(v2): Add Turkish translations for theme labels #4312
Conversation
Hi @caglarturali! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
[V1] Deploy preview failure Built without sensitive environment variables with commit bb980f0 https://app.netlify.com/sites/docusaurus-1/deploys/603d4f4fa921d20008b1747d |
Deploy preview for docusaurus-2 ready! Built without sensitive environment variables with commit bb980f0 |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-4312--docusaurus-2.netlify.app/classic/ |
Size Change: 0 B Total Size: 532 kB ℹ️ View Unchanged
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your submission!
Can you please double-check the last updated by labels so that they handle all the possible edge-cases?
"theme.lastUpdated.atDate": "{date} tarihinde", | ||
"theme.lastUpdated.byUser": "{user} tarafından", | ||
"theme.lastUpdated.lastUpdatedAtBy": "En son{atDate}{byUser} güncellendi", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me now. 😊
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks :)
Motivation
To provide default translations in Turkish.
Have you read the Contributing Guidelines on pull requests?
Yep.
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)
N/A
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)
N/A