Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(v2): Add Turkish translations for theme labels #4312

Merged
merged 2 commits into from
Mar 2, 2021
Merged

feat(v2): Add Turkish translations for theme labels #4312

merged 2 commits into from
Mar 2, 2021

Conversation

caglarturali
Copy link
Contributor

Motivation

To provide default translations in Turkish.

Have you read the Contributing Guidelines on pull requests?

Yep.

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)

N/A

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

N/A

@facebook-github-bot
Copy link
Contributor

Hi @caglarturali!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@netlify
Copy link

netlify bot commented Feb 27, 2021

@netlify
Copy link

netlify bot commented Feb 27, 2021

Deploy preview for docusaurus-2 ready!

Built without sensitive environment variables with commit bb980f0

https://deploy-preview-4312--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Feb 27, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 92
🟢 Accessibility 96
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-4312--docusaurus-2.netlify.app/classic/

@github-actions
Copy link

github-actions bot commented Feb 27, 2021

Size Change: 0 B

Total Size: 532 kB

ℹ️ View Unchanged
Filename Size Change
website/build/assets/css/styles.********.css 87.1 kB 0 B
website/build/assets/js/main.********.js 359 kB 0 B
website/build/blog/2017/12/14/introducing-docusaurus/index.html 60.3 kB 0 B
website/build/docs/introduction/index.html 235 B 0 B
website/build/index.html 25.4 kB 0 B

compressed-size-action

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Feb 27, 2021
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@lex111 lex111 added this to the v2.0.0-alpha.71 milestone Mar 1, 2021
Copy link
Collaborator

@slorber slorber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your submission!

Can you please double-check the last updated by labels so that they handle all the possible edge-cases?

packages/docusaurus-theme-classic/codeTranslations/tr.json Outdated Show resolved Hide resolved
Comment on lines +62 to +64
"theme.lastUpdated.atDate": "{date} tarihinde",
"theme.lastUpdated.byUser": "{user} tarafından",
"theme.lastUpdated.lastUpdatedAtBy": "En son{atDate}{byUser} güncellendi",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now. 😊

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks :)

@slorber slorber added the pr: new feature This PR adds a new API or behavior. label Mar 2, 2021
@slorber slorber changed the title Add Turkish translations for theme labels feat(v2): Add Turkish translations for theme labels Mar 2, 2021
This was referenced Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: new feature This PR adds a new API or behavior.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants