Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(v2): Fix link to slash introduction svg #4229

Merged
merged 1 commit into from
Feb 17, 2021
Merged

docs(v2): Fix link to slash introduction svg #4229

merged 1 commit into from
Feb 17, 2021

Conversation

SamChou19815
Copy link
Contributor

Motivation

According to #4126, we shouldn't be using baseUrl for the images in markdowns. It also broke the image on the old versioned docs (You can also see this on https://v2.docusaurus.io/docs/):

Screen Shot 2021-02-16 at 10 38 16

I replaced the img tag with markdown image link, to make it consistent with the latest docs.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Now fixed:

Screen Shot 2021-02-16 at 10 38 37

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Feb 16, 2021
@netlify
Copy link

netlify bot commented Feb 16, 2021

@github-actions
Copy link

Size Change: +15 B (0%)

Total Size: 158 kB

ℹ️ View Unchanged
Filename Size Change
website/build/assets/css/styles.********.css 17.6 kB 0 B
website/build/assets/js/main.********.js 111 kB +14 B (0%)
website/build/blog/2017/12/14/introducing-docusaurus/index.html 21.7 kB -1 B (0%)
website/build/docs/introduction/index.html 180 B 0 B
website/build/index.html 6.95 kB +2 B (0%)

compressed-size-action

@netlify
Copy link

netlify bot commented Feb 16, 2021

Deploy preview for docusaurus-2 ready!

Built without sensitive environment variables with commit 02049f0

https://deploy-preview-4229--docusaurus-2.netlify.app

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 89
🟢 Accessibility 96
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-4229--docusaurus-2.netlify.app/classic/

@slorber
Copy link
Collaborator

slorber commented Feb 17, 2021

Thanks @SamChou19815 !

I was really surprised by this problem as it worked before and I didn't change the actual code, just the doc.

Found out the issue: I enabled the English language on Crowdin by mistake, so we upload sources and redownload them as English translations.

Crowdin is yet very good to handle JSX (really hope they'll add mdx support!) and somehow convert some JSX attributes as plain strings:

image

So I'll still merge this PR, and also disabled the English language on Crowdin

@slorber slorber added pr: bug fix This PR fixes a bug in a past release. pr: documentation This PR works on the website or other text documents in the repo. and removed pr: bug fix This PR fixes a bug in a past release. labels Feb 17, 2021
@slorber slorber merged commit bb63e09 into facebook:master Feb 17, 2021
@SamChou19815 SamChou19815 deleted the unbreak-slash-introduction-image-link branch February 17, 2021 12:50
@lex111 lex111 added this to the v2.0.0-alpha.71 milestone Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants