-
-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(v2): Add Eightshift Docs site to showcase page #4053
Conversation
Hi @iruzevic! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
❌ [V1] Deploy preview failure 🔨 Explore the source changes: a69ba5c 🔍 Inspect the deploy logs: https://app.netlify.com/sites/docusaurus-1/deploys/60022dc8432b6e0008c50ae0 |
Size Change: +1 B (0%) Total Size: 26.8 kB ℹ️ View Unchanged
|
✔️ Deploy preview for docusaurus-2 ready! 🔨 Explore the source changes: a69ba5c 🔍 Inspect the deploy logs: https://app.netlify.com/sites/docusaurus-2/deploys/60022dc80d403600070cf83d 😎 Browse the preview: https://deploy-preview-4053--docusaurus-2.netlify.app |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-4053--docusaurus-2.netlify.app/classic/ |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks amazing man!
Tnx |
Motivation
The documentation of Eightshift Docs is using Docusaurus v2. It could be cool to add it in the showcase page.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Run yarn run start:v2 and check that the page http://localhost:3000/showcase is rendered properly.
Related PRs
No