-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(v2): docusaurus-init: switch from inquirer to prompts #4012
Conversation
Signed-off-by: Reece Dunham <me@rdil.rocks>
@@ -5,20 +5,27 @@ | |||
* LICENSE file in the root directory of this source tree. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some reason, copyUntypedFiles kept failing on this file locally, so I just ported it to TypeScript.
Size Change: -2 B (0%) Total Size: 26.7 kB ℹ️ View Unchanged
|
✔️ Deploy preview for docusaurus-2 ready! 🔨 Explore the source changes: b3e60b6 🔍 Inspect the deploy logs: https://app.netlify.com/sites/docusaurus-2/deploys/5ff747b54c48980007998a98 😎 Browse the preview: https://deploy-preview-4012--docusaurus-2.netlify.app |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-4012--docusaurus-2.netlify.app/classic/ |
LGTM thanks 👍 Seems to have benefits to do the switch, and would be happy to remove it from core as well. |
Signed-off-by: Reece Dunham me@rdil.rocks
Motivation
Prompts is generally better, see facebook/create-react-app#10083 for more context.
I'll switch
@docusaurus/core
over as well when I have more time.Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
I have personally confirmed it still works after these changes.
Related PRs
facebook/create-react-app#10083