document changes from PR #206 (as per issue #212) #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoelMarcey
approved these changes
Jan 8, 2018
There was a problem hiding this comment.
@filipdanic Thank you for this pull request. A nice one to get started with. :)
My only nit is that I usually do not link the periods . in a sentence. Also you probably could have just linked the "supported languages here" part. But that is a minor thing and easily fixed.
|
Closes #212 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
To get started contributing to Docusaurus, I guess? :)
Test Plan
Build the website to see the changes. (Pretty self-evident what they are.)
Related PRs
This documents the new config field that introduced by #206 and closes the issue #212.
Side note: also added the links that help people find all the themes and languages that are supported by Highlight.js