Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not set html lang attribute if there is no language set #362

Merged
merged 2 commits into from
Dec 27, 2017

Conversation

JoelMarcey
Copy link
Contributor

Motivation

Do not want

<html lang=''>

Test Plan

docusaurus-init test site and React Native did not have lang attribute
docusaurus.io and Reason-React did

Related PRs

Stemming from the changes made in #316

@JoelMarcey
Copy link
Contributor Author

cc @richardzcode

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Dec 27, 2017
@JoelMarcey JoelMarcey merged commit b0f26db into facebook:master Dec 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants