Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v2): fix Docusaurus 2 website PWA manifest #3500

Merged
merged 1 commit into from
Sep 30, 2020

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Sep 30, 2020

Motivation

Should fix the PWA installed app to start on manifest json, see #3447

@slorber slorber requested a review from yangshun as a code owner September 30, 2020 14:48
@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Sep 30, 2020
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Sep 30, 2020
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-2 ready!

Built with commit a1dbc36

https://deploy-preview-3500--docusaurus-2.netlify.app

@slorber slorber changed the title fix(v2): attempt to fix PWA manifest fix(v2): fix PWA manifest Sep 30, 2020
@slorber slorber changed the title fix(v2): fix PWA manifest fix(v2): fix Docusaurus 2 website PWA manifest Sep 30, 2020
@slorber slorber merged commit 9cbca49 into master Sep 30, 2020
@lex111 lex111 deleted the slorber/fix-pwa-manifest branch October 7, 2020 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Launching Docusaurus V2 as installed PWA on Windows just shows manifest.json instead of the site
4 participants