Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(v2): guide on upgrading Docusaurus within a project #2338

Merged
merged 4 commits into from
Feb 28, 2020
Merged

docs(v2): guide on upgrading Docusaurus within a project #2338

merged 4 commits into from
Feb 28, 2020

Conversation

TheodoreChu
Copy link
Contributor

Add information on how to update/upgrade the version of Docusaurus

@TheodoreChu
Update installation.md
ebf841b 
Add information on how to update/upgrade the version of Docusaurus
@TheodoreChu TheodoreChu requested a review from wgao19 as a code owner February 27, 2020 21:28
@facebook-github-bot
Copy link
Contributor

Hi @TheodoreChu!

Thank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Feb 27, 2020 •
edited
Loading

Deploy preview for docusaurus-2 ready!

Built with commit acd9371

https://deploy-preview-2338--docusaurus-2.netlify.com

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Feb 27, 2020
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@TheodoreChu
Copy link
Contributor Author

Thanks to @bravo-kernel for helping me figure this out.

@yangshun yangshun changed the title Update installation.md docs(v2): guide on upgrading Docusaurus within a project Feb 28, 2020
@yangshun yangshun added the pr: documentation This PR works on the website or other text documents in the repo. label Feb 28, 2020
yangshun
yangshun approved these changes Feb 28, 2020
View reviewed changes
Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR and thanks to @bravo-kernel as well! 😄

@yangshun yangshun merged commit baed4fa into facebook:master Feb 28, 2020
@TheodoreChu
Copy link
Contributor Author

@yangshun , it looks like the yarn version of the installation command isn't showing on https://v2.docusaurus.io/docs/installation#updating-your-docusaurus-version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yangshun yangshun yangshun approved these changes

@wgao19 wgao19 Awaiting requested review from wgao19

Assignees
No one assigned
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TheodoreChu @facebook-github-bot @docusaurus-bot @yangshun