fix(v2): remove hashbang when click on category #1999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for docusaurus-2 ready! Built with commit 5df7f5d |
|
Deploy preview for docusaurus-preview ready! Built with commit 5df7f5d |
5489b6d to
6dceaf6
Compare
6dceaf6 to
8d5f64d
Compare
endiliey
approved these changes
Nov 15, 2019
yangshun
approved these changes
Nov 15, 2019
| @@ -27,6 +27,11 @@ function DocSidebarItem({item, onItemClick, collapsible}) { | |||
| setCollapsed(item.collapsed); | |||
| } | |||
|
|
|||
| const handleItemClick = useCallback(e => { | |||
There was a problem hiding this comment.
This use of useCallback is premature optimization IMO.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, when you click on a category in the browser address bar, two characters "#!" (known as the hashbang) are added to the end of the URL. This is somewhat annoying and clogs the browser history.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan