refactor(theme-common): change storageUtils useSyncExternalCode getSnapshot workaround #10728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Size Change: +326 B (0%) Total Size: 11.2 MB
ℹ️ View Unchanged
|
⚡️ Lighthouse report for the deploy preview of this PR
|
|
Size Change: +316 B (0%) Total Size: 11.7 MB
ℹ️ View Unchanged
|
|
Finally understood why I haven't been successful removing this code Removing it works fine at runtime, but So, we can't fix it easily for now without rewriting the tests. I'll just update the comment instead, and only apply the workaround in tests so that it's clear that it's not actually needed in production. |
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This workaround shouldn't be needed anymore since we use React 18
Test Plan
CI
Test links
https://deploy-preview-10728--docusaurus-2.netlify.app/