-
-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-enable check #4447
Re-enable check #4447
Conversation
Re-enables check now that #2176 is closed
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
signed it 👍 |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
object: 'require', | ||
property: 'ensure', | ||
message: | ||
'Please use import() instead. More info: https://github.com/facebookincubator/create-react-app/blob/master/packages/react-scripts/template/README.md#code-splitting', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you correct the url. The repo is no longer here and you should target next
instead, as master
is no longer taking updates.
I'm pretty sure this change has already been made on the create-react-app/packages/eslint-config-react-app/index.js Lines 166 to 180 in 0f84a4b
Thanks a lot for the PR, though! |
Great! Sorry I didn't realize that the branches were switched |
Re-enables check now that #2176 is closed