Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating ESlint to ^4.15.0 and adding new rules to config #3723

Merged
merged 11 commits into from
Jan 13, 2018
Merged

Updating ESlint to ^4.15.0 and adding new rules to config #3723

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
b4c84bd
Updating ESlint to ^4.15.0 and adding new rules to config
claughlin-r7 Jan 9, 2018
6ba1aa8
remoning style rule and auto fixing breakages from new rules
claughlin-r7 Jan 9, 2018
4e41a7f
Removing implicit-arrow-linebreak style rule
claughlin-r7 Jan 9, 2018
e3d44a5
adding new rule to eslint config project
claughlin-r7 Jan 9, 2018
0d12732
updating react scripts eslint version
claughlin-r7 Jan 9, 2018
2fd903f
Merge branch 'master' into eslint-4-10-x-update
chrislaughlin Jan 9, 2018
472fdf9
Merge branch 'master' into eslint-4-10-x-update
chrislaughlin Jan 9, 2018
27ecdea
Pinning version.
chrislaughlin Jan 9, 2018
b5b7cc0
Changing getter-return to warn
chrislaughlin Jan 9, 2018
c03ca16
Update package.json
gaearon Jan 12, 2018
eace2de
Update .eslintrc
gaearon Jan 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .eslintrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
"rules": {
"no-console": "off",
"strict": ["error", "global"],
"curly": "warn"
"curly": "warn",
"getter-return": "error"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this our own eslintrc? To update the rules of our config, you'd need to change eslint-config-react-app/index.js

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah good catch, I'll update the config

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth keeping this new rule in the root eslint config for development work?

}
}
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"precommit": "lint-staged"
},
"devDependencies": {
"eslint": "^4.4.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This version is not very relevant to our users. You want to change the one in packages/react-scripts/package.json instead.

"eslint": "^4.15.0",
"husky": "^0.13.2",
"lerna": "^2.0.0",
"lerna-changelog": "^0.6.0",
Expand Down
1 change: 1 addition & 0 deletions packages/eslint-config-react-app/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,6 +239,7 @@ module.exports = {
'Please use import() instead. More info: https://github.com/facebookincubator/create-react-app/blob/master/packages/react-scripts/template/README.md#code-splitting',
},
],
'getter-return': 'error',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make this a warning rather than an error?


// https://github.com/benmosher/eslint-plugin-import/tree/master/docs/rules
'import/first': 'error',
Expand Down