Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eslint-config-react-app should provide @babel/plugin-syntax-flow and @babel/plugin-transform-react-jsx #12456

Open
quisido opened this issue Jun 1, 2022 · 3 comments

Comments

@quisido
Copy link

quisido commented Jun 1, 2022

Describe the bug

Installing eslint-config-react-app results in these two warnings:

➤ YN0002: │ eslint-config-react-app@npm:7.0.1 [41989] doesn't provide @babel/plugin-syntax-flow (pc2f30), requested by eslint-plugin-flowtype
➤ YN0002: │ eslint-config-react-app@npm:7.0.1 [41989] doesn't provide @babel/plugin-transform-react-jsx (p4cc0d), requested by eslint-plugin-flowtype

Environment

Yarn 3

Steps to reproduce

  1. yarn install

Expected behavior

eslint-config-react-app should correctly depend on @babel/plugin-syntax-flow and @babel/plugin-transform-react-jsx

Actual behavior

Warning


The fix for this is either too add @babel/plugin-syntax-flow and @babel/plugin-transform-react-jsx to the dependencies of eslint-config-react-app's package.json file or to its peerDependencies. I didn't know which is desired between the two (I assume peerDependencies, but I know ESLint can be finicky about nested dependencies), so I didn't want to cut a PR with the wrong change.

@nathan-alden-sr
Copy link

I'm seeing this, too. Also, adding the dependency to my project's list doesn't resolve the warning because the warning doesn't occur in my workspace.

@doronhorwitz
Copy link

Is there a workaround for this?

@ndmax
Copy link

ndmax commented Feb 19, 2023

@doronhorwitz Sort of: #11982

acusti added a commit to acusti/uikit that referenced this issue Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants