Fix the draggability of small objects #5379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asturur
commented
Nov 9, 2018
| _getActionFromCorner: function(target, corner, e) { | ||
| if (!corner) { | ||
| _getActionFromCorner: function(alreadySelected, corner, e) { | ||
| if (!corner || !alreadySelected) { |
There was a problem hiding this comment.
target was there, unused.
Liinntttt where are you?
|
Not proud of this code, looks like a patch. The selection and action flow is complicated enough that i do not get away with a clean and straight forward code. |
|
needs an extensive test where on an object, a simulated click checks each of the 9 corners and the center of the object and inspect the resulting action type both for an unselected object and for a selected one. |
Merged
thiagocunha
pushed a commit
to thiagocunha/fabric.js
that referenced
this pull request
Nov 18, 2019
* change to action logic * fixed test * added some tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a force rule ( we had it before somehow ) that objects cannot be scaled if not selected.
Realistically no one guess the corner position and start to drag it to scale.
Is often a drag operation that ends up with a scale one.
If you want to use a corner, first select the object.
close #5369