Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: minimizing methods in handler templates #3301

Merged
merged 1 commit into from
Jul 14, 2021
Merged

chore: minimizing methods in handler templates #3301

merged 1 commit into from
Jul 14, 2021

Conversation

shawkins
Copy link
Contributor

@shawkins shawkins commented Jul 6, 2021

Description

Chore to move implementation logic from the templates to the ResourceHandler interface.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@shawkins shawkins requested a review from manusa July 6, 2021 15:54
@centos-ci
Copy link

Can one of the admins verify this patch?

@rohanKanojia rohanKanojia requested a review from iocanel July 6, 2021 15:55
@shawkins shawkins mentioned this pull request Jul 6, 2021
Merged
11 tasks
@manusa manusa requested a review from oscerd July 12, 2021 14:15
manusa
manusa approved these changes Jul 12, 2021
View reviewed changes
Copy link
Member

@manusa manusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx!

@manusa manusa added this to the 5.6.0 milestone Jul 14, 2021
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

15.8% 15.8% Coverage
0.0% 0.0% Duplication

@manusa manusa merged commit ad080a6 into fabric8io:master Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manusa manusa manusa approved these changes

@oscerd oscerd oscerd approved these changes

@rohanKanojia rohanKanojia rohanKanojia approved these changes

@iocanel iocanel Awaiting requested review from iocanel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.6.0
Development

Successfully merging this pull request may close these issues.
5 participants
@shawkins @centos-ci @manusa @oscerd @rohanKanojia