Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if BouncyCastle provider is set #1798

Merged
merged 1 commit into from
Oct 9, 2019
Merged

Check if BouncyCastle provider is set #1798

merged 1 commit into from
Oct 9, 2019

Conversation

torrescd
Copy link
Contributor

@torrescd torrescd commented Oct 5, 2019

bcpkix-jdk15on have only 400kb instead of 4.5MB from bcprov-ext-jdk15on

With this check we can take advantage of a BouncyCastleProvider that is already set (for example by the jenkins plugin bouncycastle-api)

@centos-ci
Copy link

Can one of the admins verify this patch?

@torrescd torrescd mentioned this pull request Oct 5, 2019
Closed
@rohanKanojia
Copy link
Member

ok to test

@rohanKanojia rohanKanojia requested a review from gastaldi October 7, 2019 10:00
gastaldi
gastaldi reviewed Oct 7, 2019
View reviewed changes
Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code change looks good, but I prefer to not change the optional flag in the BC dependency, unless there is a strong reason to do so.

gastaldi
gastaldi approved these changes Oct 7, 2019
View reviewed changes
Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can you squash both commits into a single one? Thanks!

@torrescd torrescd force-pushed the feature/checkBouncyCastleProvider branch from 8452212 to 32ff65b Compare October 7, 2019 13:18
@torrescd
Copy link
Contributor Author

torrescd commented Oct 7, 2019

LGTM, can you squash both commits into a single one? Thanks!

Done!

@gastaldi
Copy link
Contributor

gastaldi commented Oct 7, 2019 •
edited
Loading

Ah almost forgot, one last thing: Can you add an entry to the CHANGELOG.md file with this change?

@torrescd torrescd force-pushed the feature/checkBouncyCastleProvider branch from 32ff65b to 8ab0819 Compare October 7, 2019 14:24
@torrescd
Copy link
Contributor Author

torrescd commented Oct 7, 2019

Ah almost forgot, one last thing: Can you add an entry to the CHANGELOG.md file with this change?

Done!

rohanKanojia
rohanKanojia approved these changes Oct 9, 2019
View reviewed changes
Copy link
Member

@rohanKanojia rohanKanojia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rohanKanojia
Copy link
Member

[merge]

@fusesource-ci fusesource-ci merged commit 8e2d7f1 into fabric8io:master Oct 9, 2019
@manusa manusa mentioned this pull request Mar 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gastaldi gastaldi gastaldi approved these changes

@oscerd oscerd oscerd approved these changes

@rohanKanojia rohanKanojia rohanKanojia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@torrescd @centos-ci @rohanKanojia @gastaldi @oscerd @fusesource-ci