Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

waitUntilCondition resource too old exception #3271

Closed
shawkins opened this issue Jun 24, 2021 · 2 comments
Closed

waitUntilCondition resource too old exception #3271

shawkins opened this issue Jun 24, 2021 · 2 comments
Assignees
Labels
Milestone

Comments

@shawkins
Copy link
Contributor

I tried to do a waitUntilCondition call, that eventually errorred out with a resource too old exception. This seems to come from WatcherException isShouldRetry - it explicitly is false when there's an http gone exception.

It should either be the other way around, or to retry no matter what the exception is.

@shawkins shawkins self-assigned this Jun 25, 2021
shawkins added a commit to shawkins/kubernetes-client that referenced this issue Jun 25, 2021
the only time to retry is on http gone
delete does not need special handling in the watcher
@manusa manusa added the bug label Jun 28, 2021
@manusa manusa added this to the 5.5.0 milestone Jun 28, 2021
@shawkins
Copy link
Contributor Author

After this change the internal wait code can be mostly cleaned up: 63d555d (not all of the tests were updated yet)

However that code shows there is inconsistent handling of the interrupted exception. At least for our own internal usage it would be better to not throw it directly from waitUntilCondition and instead use a KubernetesClientException. Since the proposed change is already breaking wrt exception handling, could we make that change as well?

The only remaining waiting scenario is a pod list scenario, which could be addressed by #3278

manusa pushed a commit to shawkins/kubernetes-client that referenced this issue Jun 29, 2021
the only time to retry is on http gone
delete does not need special handling in the watcher
@manusa
Copy link
Member

manusa commented Jun 29, 2021

...interrupted exception....instead use a KubernetesClientException...
I guess that now that the underlying behavior has changed, it no longer makes sense to have it as part of the method signature.

The change should not be breaking (strictly speaking) since KubernetesClientException is unchecked

manusa pushed a commit to shawkins/kubernetes-client that referenced this issue Jun 29, 2021
the only time to retry is on http gone
delete does not need special handling in the watcher
@manusa manusa closed this as completed in faae99d Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants