-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
waitUntilCondition resource too old exception #3271
Comments
the only time to retry is on http gone delete does not need special handling in the watcher
After this change the internal wait code can be mostly cleaned up: 63d555d (not all of the tests were updated yet) However that code shows there is inconsistent handling of the interrupted exception. At least for our own internal usage it would be better to not throw it directly from waitUntilCondition and instead use a KubernetesClientException. Since the proposed change is already breaking wrt exception handling, could we make that change as well? The only remaining waiting scenario is a pod list scenario, which could be addressed by #3278 |
the only time to retry is on http gone delete does not need special handling in the watcher
The change should not be breaking (strictly speaking) since KubernetesClientException is unchecked |
the only time to retry is on http gone delete does not need special handling in the watcher
I tried to do a waitUntilCondition call, that eventually errorred out with a resource too old exception. This seems to come from WatcherException isShouldRetry - it explicitly is false when there's an http gone exception.
It should either be the other way around, or to retry no matter what the exception is.
The text was updated successfully, but these errors were encountered: