Skip to content
This repository has been archived by the owner on Oct 5, 2022. It is now read-only.

The readinessProbe should support setting the scheme #5909

Closed
KurtStam opened this issue Apr 6, 2016 · 3 comments
Closed

The readinessProbe should support setting the scheme #5909

KurtStam opened this issue Apr 6, 2016 · 3 comments
Assignees
@KurtStam
Labels
maven

Comments

@KurtStam
Copy link
Member

KurtStam commented Apr 6, 2016

That way it can probe SSL services.
@KurtStam KurtStam self-assigned this Apr 6, 2016
@KurtStam KurtStam added the maven label Apr 6, 2016
KurtStam pushed a commit to KurtStam/fabric8 that referenced this issue Apr 6, 2016
Support setting the scheme in the readinessProbe, issue fabric8io#5909
11c7cb6
@rhuss
Copy link
Contributor

rhuss commented Apr 6, 2016

Funny, its exactly the current spot where I am in my refactoring journey :). In the new plugin you will be able to set a full URL (including protocol).

@KurtStam
Copy link
Member Author

KurtStam commented Apr 6, 2016

With this change, it now supports httpGet.scheme. Testing showed that it is successfully ignoring the validity of the certificate, so you can use a self signed cert (kubernetes/kubernetes#9866).

@KurtStam
Copy link
Member Author

KurtStam commented Apr 6, 2016

@rhuss that sure is funny!

@KurtStam KurtStam closed this as completed Apr 6, 2016
dhirajsb pushed a commit to dhirajsb/fabric8 that referenced this issue Apr 8, 2016
@dhirajsb
Support setting the scheme in the readinessProbe, issue fabric8io#5909
7aeec7e
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@KurtStam KurtStam

Labels
maven
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@KurtStam @rhuss