Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logger to HTTP ping checker #1689

Merged
merged 1 commit into from
Jul 28, 2023
Merged

Add logger to HTTP ping checker #1689

merged 1 commit into from
Jul 28, 2023

Conversation

ryanrishi
Copy link
Contributor

Adds logging to HTTP wait checker. Also added a test for this class.

Signed-off-by: Ryan Rishi <ryan@ryanrishi.com>
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

60.0% 60.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Merging #1689 (8b8628a) into master (6eeb78a) will increase coverage by 0.04%.
The diff coverage is 60.00%.

❗ Current head 8b8628a differs from pull request most recent head 28084fd. Consider uploading reports for the commit 28084fd to get more accurate results

@@             Coverage Diff              @@
##             master    #1689      +/-   ##
============================================
+ Coverage     64.01%   64.06%   +0.04%     
  Complexity     2198     2198              
============================================
  Files           171      171              
  Lines          9985     9989       +4     
  Branches       1371     1371              
============================================
+ Hits           6392     6399       +7     
+ Misses         3058     3055       -3     
  Partials        535      535              
Impacted Files Coverage Δ
...a/io/fabric8/maven/docker/service/WaitService.java 4.23% <0.00%> (ø)
.../io/fabric8/maven/docker/wait/HttpPingChecker.java 60.00% <85.71%> (+9.01%) ⬆️

@rohanKanojia rohanKanojia merged commit bb612ed into fabric8io:master Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants