Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve vulnerabilities, unified dependency handling, used monkey patching for draining out older messages than given time and fixed logic to get correct number of github contributors. #909

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

jparsai
Copy link
Contributor

@jparsai jparsai commented Jul 29, 2020

Description

  • Used monkey patching to ingest the logic in Selinon to drain out messages older than given time.
  • Installed Selinon from PyPi repository instead of binary file.
  • Introduced a new Env variable to configure time limit for removing messages from Selinon
  • Added a utility function to get number of github contributors using pagination on github API
  • Resolved vulnerabilities and used updated versions of the dependencies.
  • Moved any test specific packages from requirements.in to tests/requirements.in
  • Moved any direct pip installations from Dockerfile.* to requirements.in
  • Provided relative versioning in requirements.in & tests/requirements.in
  • Generated requirements.txt and tests/requirements.txt using pip compiler
  • Updated setup.py to use requirement.in

Issues

APPAI-1409/1359/1430

@centos-ci
Copy link
Collaborator

@jparsai Your image is available in the registry: docker pull quay.io/openshiftio/rhel-bayesian-cucos-worker:SNAPSHOT-PR-909

@codecov-commenter
Copy link

codecov-commenter commented Jul 29, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@4e822f7). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #909   +/-   ##
=========================================
  Coverage          ?   64.55%           
=========================================
  Files             ?       73           
  Lines             ?     5377           
  Branches          ?        0           
=========================================
  Hits              ?     3471           
  Misses            ?     1906           
  Partials          ?        0           
Impacted Files Coverage Δ
f8a_worker/storages/s3_readme.py 33.33% <0.00%> (ø)
f8a_worker/workers/schemas/source_licenses.py 100.00% <0.00%> (ø)
f8a_worker/workers/license.py 89.55% <0.00%> (ø)
f8a_worker/workers/schemas/metadata.py 100.00% <0.00%> (ø)
f8a_worker/storages/s3.py 42.62% <0.00%> (ø)
f8a_worker/object_cache.py 48.64% <0.00%> (ø)
f8a_worker/celery_settings.py 70.00% <0.00%> (ø)
f8a_worker/storages/s3_temp_artifacts.py 78.57% <0.00%> (ø)
f8a_worker/dispatcher/selective.py 25.00% <0.00%> (ø)
f8a_worker/schemas.py 79.80% <0.00%> (ø)
... and 63 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e822f7...7fe9086. Read the comment docs.

@centos-ci
Copy link
Collaborator

@jparsai Your image is available in the registry: docker pull quay.io/openshiftio/rhel-bayesian-cucos-worker:SNAPSHOT-PR-909

1 similar comment
@centos-ci
Copy link
Collaborator

@jparsai Your image is available in the registry: docker pull quay.io/openshiftio/rhel-bayesian-cucos-worker:SNAPSHOT-PR-909

…g and use Monkey patching for draining out older messages than given time.
@centos-ci
Copy link
Collaborator

@jparsai Your image is available in the registry: docker pull quay.io/openshiftio/rhel-bayesian-cucos-worker:SNAPSHOT-PR-909

1 similar comment
@centos-ci
Copy link
Collaborator

@jparsai Your image is available in the registry: docker pull quay.io/openshiftio/rhel-bayesian-cucos-worker:SNAPSHOT-PR-909

@jparsai jparsai changed the title Resolve vulnerabilities, unified dependency handling, use monkey patching for draining out older messages than given time and fixed logic to get correct number of github contributors. Resolve vulnerabilities, unified dependency handling, used monkey patching for draining out older messages than given time and fixed logic to get correct number of github contributors. Jul 30, 2020
@centos-ci
Copy link
Collaborator

@jparsai Your image is available in the registry: docker pull quay.io/openshiftio/rhel-bayesian-cucos-worker:SNAPSHOT-PR-909

@centos-ci
Copy link
Collaborator

@jparsai Your image is available in the registry: docker pull quay.io/openshiftio/rhel-bayesian-cucos-worker:SNAPSHOT-PR-909

@centos-ci
Copy link
Collaborator

@jparsai Your image is available in the registry: docker pull quay.io/openshiftio/rhel-bayesian-cucos-worker:SNAPSHOT-PR-909

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants